[webkit-changes] [WebKit/WebKit] 2c4197: [scroll-animations] scroll timelines should clamp ...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2c4197c1bccc5b6bba8ceb5d5a491f6f7e923b61
      https://github.com/WebKit/WebKit/commit/2c4197c1bccc5b6bba8ceb5d5a491f6f7e923b61
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2024-10-18 (Fri, 18 Oct 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/platform/ios/TestExpectations
    M LayoutTests/platform/mac/TestExpectations
    A LayoutTests/webanimations/scroll-timeline-clamped-current-time-while-rubber-banding-ios-expected.txt
    A LayoutTests/webanimations/scroll-timeline-clamped-current-time-while-rubber-banding-ios.html
    A LayoutTests/webanimations/scroll-timeline-clamped-current-time-while-rubber-banding-mac-expected.txt
    A LayoutTests/webanimations/scroll-timeline-clamped-current-time-while-rubber-banding-mac.html
    M Source/WebCore/animation/ScrollTimeline.cpp

  Log Message:
  -----------
  [scroll-animations] scroll timelines should clamp their current time between `0%` and `100%`.
https://bugs.webkit.org/show_bug.cgi?id=281690
rdar://138141442

Reviewed by Simon Fraser.

Ensure we clip the scroll offset to be within the minimum and maximum scroll offsets for scroll timelines.
The spec doesn't call this out but this is Chrome's behavior. The issue https://github.com/w3c/csswg-drafts/issues/11033
was filed to discuss this, but we should match that behavior for compatibility.

* LayoutTests/TestExpectations:
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:
* LayoutTests/webanimations/scroll-timeline-clamped-current-time-while-rubber-banding-ios-expected.txt: Added.
* LayoutTests/webanimations/scroll-timeline-clamped-current-time-while-rubber-banding-ios.html: Added.
* LayoutTests/webanimations/scroll-timeline-clamped-current-time-while-rubber-banding-mac-expected.txt: Added.
* LayoutTests/webanimations/scroll-timeline-clamped-current-time-while-rubber-banding-mac.html: Added.
* Source/WebCore/animation/ScrollTimeline.cpp:
(WebCore::ScrollTimeline::computeTimelineData const):

Canonical link: https://commits.webkit.org/285416@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications