[webkit-changes] [WebKit/WebKit] ff546a: AX: Implement NextSentenceEnd/PrevSentenceStart AP...

[Joshua Hoffman]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ff546a4b6c04ed6c47dc1851f3f1268ac7e99a85
      https://github.com/WebKit/WebKit/commit/ff546a4b6c04ed6c47dc1851f3f1268ac7e99a85
  Author: Joshua Hoffman <jhoffman23 at apple.com>
  Date:   2024-10-18 (Fri, 18 Oct 2024)

  Changed paths:
    M LayoutTests/accessibility/ax-thread-text-apis/text-marker-sentence-nav-expected.txt
    M LayoutTests/accessibility/ax-thread-text-apis/text-marker-sentence-nav.html
    M Source/WebCore/accessibility/AXTextMarker.cpp
    M Source/WebCore/accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm
    M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm

  Log Message:
  -----------
  AX: Implement NextSentenceEnd/PrevSentenceStart APIs off of the main thread
https://bugs.webkit.org/show_bug.cgi?id=281541
rdar://138005738

Reviewed by Tyler Wilcock and Andres Gonzalez.

Moving NextSentenceEnd and PreviousSentenceStart off of the main thread allows the rest
of text-marker-sentence-nav.html to be ported to ax-thread-text-apis/. This patch updates
how we handle `AXTextUnit::Sentence` to appropriately handle these APIs and match the
existing live tree behavior. This test fully passes when run with AX_THREAD_TEXT_APIS
enabled.

This also includes build fixes after 285102 at main (Port AXID to ObjectIdentifier).

* LayoutTests/accessibility/ax-thread-text-apis/text-marker-sentence-nav-expected.txt:
* LayoutTests/accessibility/ax-thread-text-apis/text-marker-sentence-nav.html:
* Source/WebCore/accessibility/AXTextMarker.cpp:
(WebCore::AXTextMarker::characterRangeForLine const):
(WebCore::AXTextMarker::lineNumberForIndex const):
(WebCore::AXTextMarker::findLastBefore const):
(WebCore::previousSentenceStartFromOffset):
(WebCore::nextSentenceEndFromOffset):
(WebCore::AXTextMarker::findMarker const):
(WebCore::AXTextMarker::sentenceRange const):
* Source/WebCore/accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm:
(WebCore::AXIsolatedObject::textMarkerRange const):
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper textMarkerForTextMarker:atUnit:]):

Canonical link: https://commits.webkit.org/285413@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications