[webkit-changes] [WebKit/WebKit] 23f40f: [FFC][Integration] Take writing-mode into account ...

Alan Baradlay noreply at github.com
Fri Oct 18 07:21:05 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 23f40f9dd2122e0e3a9946df20aed4c479256b03
      https://github.com/WebKit/WebKit/commit/23f40f9dd2122e0e3a9946df20aed4c479256b03
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-10-18 (Fri, 18 Oct 2024)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.cpp
    M Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.cpp

  Log Message:
  -----------
  [FFC][Integration] Take writing-mode into account when computing flex item geometry
https://bugs.webkit.org/show_bug.cgi?id=281715

Reviewed by Antti Koivisto.

Let isMainAxisParallelWithInlineAxis consult writing mode. It makes the rest of the flex
layout unaware of the actual writing mode.

* Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::setFlexItemsGeometry):
* Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.cpp:
(WebCore::Layout::FlexFormattingUtils::isMainAxisParallelWithInlineAxis):
* Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.cpp:
(WebCore::LayoutIntegration::FlexLayout::layout):
(WebCore::LayoutIntegration::FlexLayout::updateRenderers):

Canonical link: https://commits.webkit.org/285401@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list