[webkit-changes] [WebKit/WebKit] 1335f9: [FFC][Integration] Take writing-mode into account ...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1335f905255a572d800b1461f05aa3ffcc280450
      https://github.com/WebKit/WebKit/commit/1335f905255a572d800b1461f05aa3ffcc280450
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-10-18 (Fri, 18 Oct 2024)

  Changed paths:
    M Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.cpp
    M Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.h
    M Source/WebCore/rendering/RenderFlexibleBox.cpp

  Log Message:
  -----------
  [FFC][Integration] Take writing-mode into account when computing main/cross axis constraints
https://bugs.webkit.org/show_bug.cgi?id=281677

Reviewed by Antti Koivisto.

1. Move constraint computation to a dedicated function.
2. Take writing-mode into account so that FlexFormattingContext sees
  main axis constraint -> the main direction flex items are placed
  cross axis constraint -> the cross direction flex items are placed

e.g.
  <flex container style="writing-mode: vertical-lr; width: 100px; height: 50px;">
    <flex item>
  main constraint -> 50px
  cross constraint -> 100px
  (assuming initial value of flex-direction: row)

* LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flexbox-writing-mode-002.html:
* Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.cpp:
(WebCore::LayoutIntegration::constraintsForFlexContent):
(WebCore::LayoutIntegration::FlexLayout::updateFormattingContexGeometries):
(WebCore::LayoutIntegration::FlexLayout::layout):
(WebCore::LayoutIntegration::flexBoxLogicalBorder): Deleted.
(WebCore::LayoutIntegration::flexBoxLogicalPadding): Deleted.
* Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.h:
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutUsingFlexFormattingContext):

Canonical link: https://commits.webkit.org/285392@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications