[webkit-changes] [WebKit/WebKit] dde95a: [libpas] Centralize most logging flags

Marcus Plutowski noreply at github.com
Thu Oct 17 14:10:23 PDT 2024 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dde95ad41f4e3b5bf46336bf9e47433818a1c569
      https://github.com/WebKit/WebKit/commit/dde95ad41f4e3b5bf46336bf9e47433818a1c569
  Author: Marcus Plutowski <marcus_plutowski at apple.com>
  Date:   2024-10-17 (Thu, 17 Oct 2024)

  Changed paths:
    M Source/bmalloc/libpas/src/libpas/jit_heap.c
    M Source/bmalloc/libpas/src/libpas/pas_bitfit_allocator.c
    M Source/bmalloc/libpas/src/libpas/pas_bitfit_allocator_inlines.h
    M Source/bmalloc/libpas/src/libpas/pas_bitfit_directory.c
    M Source/bmalloc/libpas/src/libpas/pas_bitfit_heap.c
    M Source/bmalloc/libpas/src/libpas/pas_bitfit_page.c
    M Source/bmalloc/libpas/src/libpas/pas_bitfit_page_inlines.h
    M Source/bmalloc/libpas/src/libpas/pas_bitfit_view.c
    M Source/bmalloc/libpas/src/libpas/pas_bootstrap_free_heap.c
    M Source/bmalloc/libpas/src/libpas/pas_bootstrap_heap_page_provider.c
    M Source/bmalloc/libpas/src/libpas/pas_compact_bootstrap_free_heap.c
    M Source/bmalloc/libpas/src/libpas/pas_config.h
    M Source/bmalloc/libpas/src/libpas/pas_deallocate.c
    M Source/bmalloc/libpas/src/libpas/pas_deallocate.h
    M Source/bmalloc/libpas/src/libpas/pas_enumerate_bitfit_heaps.c
    M Source/bmalloc/libpas/src/libpas/pas_enumerate_segregated_heaps.c
    M Source/bmalloc/libpas/src/libpas/pas_fast_large_free_heap.c
    M Source/bmalloc/libpas/src/libpas/pas_heap.c
    M Source/bmalloc/libpas/src/libpas/pas_heap_inlines.h
    M Source/bmalloc/libpas/src/libpas/pas_heap_table.h
    M Source/bmalloc/libpas/src/libpas/pas_immortal_heap.c
    M Source/bmalloc/libpas/src/libpas/pas_large_free_heap_helpers.c
    M Source/bmalloc/libpas/src/libpas/pas_large_heap.c
    M Source/bmalloc/libpas/src/libpas/pas_large_map.c
    M Source/bmalloc/libpas/src/libpas/pas_local_allocator.c
    M Source/bmalloc/libpas/src/libpas/pas_local_allocator_inlines.h
    M Source/bmalloc/libpas/src/libpas/pas_page_malloc.c
    M Source/bmalloc/libpas/src/libpas/pas_segregated_directory.c
    M Source/bmalloc/libpas/src/libpas/pas_segregated_directory_inlines.h
    M Source/bmalloc/libpas/src/libpas/pas_segregated_exclusive_view.c
    M Source/bmalloc/libpas/src/libpas/pas_segregated_exclusive_view_inlines.h
    M Source/bmalloc/libpas/src/libpas/pas_segregated_heap.c
    M Source/bmalloc/libpas/src/libpas/pas_segregated_page.c
    M Source/bmalloc/libpas/src/libpas/pas_segregated_page.h
    M Source/bmalloc/libpas/src/libpas/pas_segregated_page_inlines.h
    M Source/bmalloc/libpas/src/libpas/pas_segregated_partial_view.c
    M Source/bmalloc/libpas/src/libpas/pas_segregated_shared_handle.c
    M Source/bmalloc/libpas/src/libpas/pas_segregated_shared_handle_inlines.h
    M Source/bmalloc/libpas/src/libpas/pas_segregated_shared_page_directory.c
    M Source/bmalloc/libpas/src/libpas/pas_segregated_shared_view.c
    M Source/bmalloc/libpas/src/libpas/pas_segregated_size_directory.c
    M Source/bmalloc/libpas/src/libpas/pas_segregated_size_directory_inlines.h
    M Source/bmalloc/libpas/src/libpas/pas_segregated_view.c
    M Source/bmalloc/libpas/src/libpas/pas_segregated_view_allocator_inlines.h
    M Source/bmalloc/libpas/src/libpas/pas_simple_large_free_heap.c
    M Source/bmalloc/libpas/src/libpas/pas_try_allocate.h
    M Source/bmalloc/libpas/src/libpas/pas_try_allocate_common.h
    M Source/bmalloc/libpas/src/libpas/pas_try_allocate_intrinsic.h
    M Source/bmalloc/libpas/src/libpas/pas_try_reallocate.h

  Log Message:
  -----------
  [libpas] Centralize most logging flags
https://bugs.webkit.org/show_bug.cgi?id=280975
rdar://137427586

Reviewed by Mark Lam.

Previously, these flags had to be enabled one-by-one for each file (and
often each function) you wanted to log from. Now the most common -- at
least in my experience -- collections of log-prints can be enabled by
changing PAS_LOG_LEVEL to include whichever levels should be logged.

I didn't cover all of the verbose prints in libpas, as some of the
others are particularly spammy or would otherwise need some cleanup
before they could be used. I also left the existing verbose flags
in-place in case they're part of anyone's workflow.

* Source/bmalloc/libpas/src/libpas/jit_heap.c:
(jit_heap_add_fresh_memory):
(jit_heap_try_allocate):
(jit_heap_shrink):
(jit_heap_deallocate):
* Source/bmalloc/libpas/src/libpas/pas_bitfit_allocator.c:
(pas_bitfit_allocator_commit_view):
(pas_bitfit_allocator_finish_failing):
* Source/bmalloc/libpas/src/libpas/pas_bitfit_allocator_inlines.h:
(pas_bitfit_allocator_try_allocate):
* Source/bmalloc/libpas/src/libpas/pas_bitfit_directory.c:
(pas_bitfit_directory_construct):
(pas_bitfit_directory_get_first_free_view):
(pas_bitfit_directory_take_last_empty):
* Source/bmalloc/libpas/src/libpas/pas_bitfit_heap.c:
(pas_bitfit_heap_select_variant):
(pas_bitfit_heap_construct_and_insert_size_class):
* Source/bmalloc/libpas/src/libpas/pas_bitfit_page.c:
(pas_bitfit_page_construct):
* Source/bmalloc/libpas/src/libpas/pas_bitfit_page_inlines.h:
(pas_bitfit_page_allocation_satisfies_alignment):
(pas_bitfit_page_finish_allocation):
(pas_bitfit_page_allocate):
(pas_bitfit_page_deallocate_with_page_impl):
* Source/bmalloc/libpas/src/libpas/pas_bitfit_view.c:
(pas_bitfit_view_create):
(compute_summary):
* Source/bmalloc/libpas/src/libpas/pas_bootstrap_free_heap.c:
(bootstrap_source_allocate_aligned):
* Source/bmalloc/libpas/src/libpas/pas_bootstrap_heap_page_provider.c:
(pas_bootstrap_heap_page_provider):
* Source/bmalloc/libpas/src/libpas/pas_compact_bootstrap_free_heap.c:
(compact_bootstrap_source_allocate_aligned):
* Source/bmalloc/libpas/src/libpas/pas_config.h:
* Source/bmalloc/libpas/src/libpas/pas_deallocate.c:
(pas_try_deallocate_slow_no_cache):
* Source/bmalloc/libpas/src/libpas/pas_deallocate.h:
(pas_try_deallocate):
* Source/bmalloc/libpas/src/libpas/pas_enumerate_bitfit_heaps.c:
(view_callback):
* Source/bmalloc/libpas/src/libpas/pas_enumerate_segregated_heaps.c:
(record_page_objects):
(enumerate_exclusive_view):
(enumerate_shared_view):
(enumerate_partial_view):
(consider_allocator):
* Source/bmalloc/libpas/src/libpas/pas_fast_large_free_heap.c:
(pas_fast_large_free_heap_try_allocate):
(pas_fast_large_free_heap_deallocate):
* Source/bmalloc/libpas/src/libpas/pas_heap.c:
(pas_heap_create):
* Source/bmalloc/libpas/src/libpas/pas_heap_inlines.h:
(pas_heap_ensure_size_directory_for_size):
* Source/bmalloc/libpas/src/libpas/pas_heap_table.h:
(pas_heap_table_has_index):
* Source/bmalloc/libpas/src/libpas/pas_immortal_heap.c:
(pas_immortal_heap_allocate_with_manual_alignment):
(pas_immortal_heap_allocate_with_alignment):
* Source/bmalloc/libpas/src/libpas/pas_large_free_heap_helpers.c:
(large_utility_aligned_allocator):
(pas_large_free_heap_helpers_try_allocate_with_alignment):
(pas_large_free_heap_helpers_deallocate):
* Source/bmalloc/libpas/src/libpas/pas_large_heap.c:
(allocate_impl):
* Source/bmalloc/libpas/src/libpas/pas_large_map.c:
(pas_large_map_add):
(pas_large_map_take):
* Source/bmalloc/libpas/src/libpas/pas_local_allocator.c:
(pas_local_allocator_construct):
(stop_impl):
(pas_local_allocator_stop):
* Source/bmalloc/libpas/src/libpas/pas_local_allocator_inlines.h:
(pas_local_allocator_scan_bits_to_set_up_free_bits):
(pas_local_allocator_prepare_to_allocate):
(pas_local_allocator_set_up_primordial_bump):
(pas_local_allocator_start_allocating_in_primordial_partial_view):
(pas_local_allocator_bless_primordial_partial_view_before_stopping):
(pas_local_allocator_refill_with_known_config):
(pas_local_allocator_return_memory_to_page_for_role):
(pas_local_allocator_try_allocate_with_free_bits):
(pas_local_allocator_try_allocate_inline_cases):
(pas_local_allocator_try_allocate_out_of_line_cases):
(pas_local_allocator_try_allocate_slow_impl):
(pas_local_allocator_try_allocate_inline_only):
(pas_local_allocator_try_allocate):
* Source/bmalloc/libpas/src/libpas/pas_page_malloc.c:
(pas_page_malloc_try_allocate_without_deallocating_padding):
(decommit_impl):
* Source/bmalloc/libpas/src/libpas/pas_segregated_directory.c:
(pas_segregated_directory_get_use_epoch):
(pas_segregated_directory_get_sharing_payload):
(pas_segregated_directory_view_did_become_empty_at_index):
* Source/bmalloc/libpas/src/libpas/pas_segregated_directory_inlines.h:
(pas_segregated_directory_iterate_iterate_callback):
(pas_segregated_directory_iterate_forward):
(pas_segregated_directory_iterate_forward_to_take_first_eligible):
* Source/bmalloc/libpas/src/libpas/pas_segregated_exclusive_view.c:
(pas_segregated_exclusive_view_create):
* Source/bmalloc/libpas/src/libpas/pas_segregated_exclusive_view_inlines.h:
(pas_segregated_exclusive_view_did_start_allocating):
(pas_segregated_exclusive_view_did_stop_allocating):
(pas_segregated_exclusive_view_note_eligibility):
* Source/bmalloc/libpas/src/libpas/pas_segregated_heap.c:
(max_object_size_for_page_config):
(max_segregated_object_size_for_heap):
(max_bitfit_object_size_for_heap):
(medium_directory_tuple_for_index_impl):
(pas_segregated_heap_medium_directory_tuple_for_index):
(pas_segregated_heap_medium_allocator_index_for_index):
(ensure_size_lookup):
(pas_segregated_heap_ensure_allocator_index):
(compute_ideal_object_size):
(check_part_of_all_heaps_callback):
(pas_segregated_heap_ensure_size_directory_for_size):
* Source/bmalloc/libpas/src/libpas/pas_segregated_page.c:
(pas_segregated_page_switch_lock_slow):
(pas_segregated_page_construct):
(pas_segregated_page_note_emptiness):
(pas_segregated_page_take_empty_granules):
(pas_segregated_page_commit_fully):
(verify_granules_live_object_callback):
(pas_segregated_page_verify_granules):
* Source/bmalloc/libpas/src/libpas/pas_segregated_page.h:
(pas_segregated_page_number_of_objects):
* Source/bmalloc/libpas/src/libpas/pas_segregated_page_inlines.h:
(pas_segregated_page_switch_lock_impl):
(pas_segregated_page_deallocate_with_page):
* Source/bmalloc/libpas/src/libpas/pas_segregated_partial_view.c:
(pas_segregated_partial_view_create):
(pas_segregated_partial_view_note_eligibility):
(pas_segregated_partial_view_set_is_in_use_for_allocation):
* Source/bmalloc/libpas/src/libpas/pas_segregated_shared_handle.c:
(pas_segregated_shared_handle_note_emptiness):
* Source/bmalloc/libpas/src/libpas/pas_segregated_shared_handle_inlines.h:
(pas_segregated_shared_handle_partial_view_ptr_for_index):
(pas_segregated_shared_handle_partial_view_for_object):
* Source/bmalloc/libpas/src/libpas/pas_segregated_shared_page_directory.c:
(find_first_eligible_consider_view):
(pas_segregated_shared_page_directory_find_first_eligible):
(take_last_empty_consider_view):
* Source/bmalloc/libpas/src/libpas/pas_segregated_shared_view.c:
(compute_summary_for_each_live_object_callback):
(compute_summary):
* Source/bmalloc/libpas/src/libpas/pas_segregated_size_directory.c:
(pas_segregated_size_directory_create):
(take_first_eligible_direct_create_new_view_callback):
(pas_segregated_size_directory_take_first_eligible):
(take_last_empty_consider_view):
* Source/bmalloc/libpas/src/libpas/pas_segregated_size_directory_inlines.h:
(pas_segregated_size_directory_num_allocator_indices_for_config):
(pas_segregated_size_directory_take_first_eligible_impl):
* Source/bmalloc/libpas/src/libpas/pas_segregated_view.c:
(for_each_live_object):
(should_be_eligible):
(pas_segregated_view_should_be_eligible):
* Source/bmalloc/libpas/src/libpas/pas_segregated_view_allocator_inlines.h:
(pas_segregated_view_will_start_allocating):
(pas_segregated_view_did_stop_allocating):
* Source/bmalloc/libpas/src/libpas/pas_try_allocate.h:
(pas_try_allocate_impl_inline_only):
* Source/bmalloc/libpas/src/libpas/pas_try_allocate_common.h:
(pas_try_allocate_common_impl_fast):
(pas_try_allocate_common_impl_slow):
(pas_try_allocate_common_impl):
* Source/bmalloc/libpas/src/libpas/pas_try_allocate_intrinsic.h:
(pas_try_allocate_intrinsic_impl_casual_case):
(pas_try_allocate_intrinsic_impl_inline_only):
* Source/bmalloc/libpas/src/libpas/pas_try_reallocate.h:
(pas_try_allocate_for_reallocate_and_copy):
(pas_try_reallocate_primitive_allocate_callback):

Canonical link: https://commits.webkit.org/285358@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications

More information about the webkit-changes mailing list