[webkit-changes] [WebKit/WebKit] 4de859: [IsDeprecatedWeakRefSmartPointerException] Make mo...

[Basuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4de859dce063802780052a99ac2045701e391853
      https://github.com/WebKit/WebKit/commit/4de859dce063802780052a99ac2045701e391853
  Author: Basuke Suzuki <basuke at apple.com>
  Date:   2024-10-17 (Thu, 17 Oct 2024)

  Changed paths:
    M Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidConnection.h
    M Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidConnection.mm
    M Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidService.h
    M Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidService.mm
    M Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidConnection.cpp
    M Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidConnection.h
    M Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidService.cpp
    M Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidService.h
    M Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualHidConnection.cpp
    M Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualHidConnection.h
    M Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualService.mm
    M Source/WebKit/UIProcess/WebAuthentication/fido/CtapHidDriver.cpp
    M Source/WebKit/UIProcess/WebAuthentication/fido/CtapHidDriver.h

  Log Message:
  -----------
  [IsDeprecatedWeakRefSmartPointerException] Make more WebAuthentication classes RefCounted
https://bugs.webkit.org/show_bug.cgi?id=281637

Reviewed by Chris Dumez.

HidConnection class and its subclasses in WebAuthentication are managed as WeakPtr so they should be ref counted.

* Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidConnection.h:
* Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidConnection.mm:
(WebKit::HidConnection::create):
* Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidService.h:
* Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidService.mm:
(WebKit::HidService::createHidConnection const):
* Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidConnection.cpp:
(WebKit::MockHidConnection::create):
* Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidConnection.h:
* Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidService.cpp:
(WebKit::MockHidService::createHidConnection const):
* Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidService.h:
* Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualHidConnection.cpp:
(WebKit::VirtualHidConnection::create):
* Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualHidConnection.h:
* Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualService.mm:
(WebKit::VirtualService::startDiscoveryInternal):
* Source/WebKit/UIProcess/WebAuthentication/fido/CtapHidDriver.cpp:
(WebKit::CtapHidDriverWorker::CtapHidDriverWorker):
(WebKit::CtapHidDriverWorker::~CtapHidDriverWorker):
(WebKit::CtapHidDriverWorker::transact):
(WebKit::CtapHidDriverWorker::write):
(WebKit::CtapHidDriverWorker::reset):
(WebKit::CtapHidDriverWorker::cancel):
(WebKit::CtapHidDriver::CtapHidDriver):
* Source/WebKit/UIProcess/WebAuthentication/fido/CtapHidDriver.h:
(WebKit::CtapHidDriverWorker::protectedConnection):

Canonical link: https://commits.webkit.org/285345@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications