[webkit-changes] [WebKit/WebKit] 53c561: REGRESSION(284010 at main): White area around YouTube...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 53c5612fe347798118ba5ed646fc15b1cd5b4b50
      https://github.com/WebKit/WebKit/commit/53c5612fe347798118ba5ed646fc15b1cd5b4b50
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-10-17 (Thu, 17 Oct 2024)

  Changed paths:
    M Source/WebCore/css/CSSPrimitiveValueMappings.h
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/page/Quirks.cpp
    M Source/WebCore/page/Quirks.h
    M Source/WebCore/style/StyleAdjuster.cpp
    M Source/WebCore/style/StyleBuilderConverter.h

  Log Message:
  -----------
  REGRESSION(284010 at main): White area around YouTube autocomplete popup
https://bugs.webkit.org/show_bug.cgi?id=281652
rdar://137387751

Reviewed by Simon Fraser.

284010 at main forced the CSS color-scheme of YouTube to dark when YouTube in dark mode, to ensure
the natively drawn scrollbars (triggered by `scrollbar-width: thin`) don't draw with a
light color scheme looking out of place.

Unfortunately, setting the CSS color-scheme to dark has the side-effect of adding a white background
to iframes with mismatching color-scheme. That is visible with the iframe that appears behind the
YouTube search autocomplete popup.

Fix the original issue in 284010 at main by disabling `scrollbar-width: thin` on YouTube, so custom
drawn scrollbars styled using `::-webkit-scrollbar` pseudo-elements are used once again.

* Source/WebCore/css/CSSPrimitiveValueMappings.h:
(WebCore::TypeDeducingCSSValueMapper::TypeDeducingCSSValueMapper):
(WebCore::fromCSSValueDeducingType):
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::needsScrollbarWidthThinDisabledQuirk const):
(WebCore::Quirks::needsYouTubeDarkModeQuirk const): Deleted.
* Source/WebCore/page/Quirks.h:
* Source/WebCore/style/StyleAdjuster.cpp:
(WebCore::Style::Adjuster::adjustForSiteSpecificQuirks const):
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertScrollbarWidth):

Canonical link: https://commits.webkit.org/285343@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications