[webkit-changes] [WebKit/WebKit] a28255: REGRESSION(283414 at main): [WPE][GTK] Crash in Proce...

[Michael Catanzaro]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a28255d5d405dae978aa9ce9301c6b78daf5703c
      https://github.com/WebKit/WebKit/commit/a28255d5d405dae978aa9ce9301c6b78daf5703c
  Author: Michael Catanzaro <mcatanzaro at redhat.com>
  Date:   2024-10-17 (Thu, 17 Oct 2024)

  Changed paths:
    M Source/WTF/wtf/glib/GSocketMonitor.cpp
    M Source/WTF/wtf/glib/GSocketMonitor.h

  Log Message:
  -----------
  REGRESSION(283414 at main): [WPE][GTK] Crash in ProcessLauncher socket monitor callback
https://bugs.webkit.org/show_bug.cgi?id=281495

Reviewed by Carlos Garcia Campos.

The socket monitor callback that I added in 283414 at main accidentally
deletes itself by calling m_socketMonitor.stop(). This causes the lambda
capture to itself be deleted. We can change the socket monitor to wait
until the callback has finished before deleting it.

* Source/WTF/wtf/glib/GSocketMonitor.cpp:
(WTF::GSocketMonitor::~GSocketMonitor):
(WTF::GSocketMonitor::socketSourceCallback):
(WTF::GSocketMonitor::stop):

Canonical link: https://commits.webkit.org/285339@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications