[webkit-changes] [WebKit/WebKit] c5a932: [WGSL] shader, validation, shader_io, align:* is failing

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c5a93258333f65c7ffdff8de27d429d5e6eff40b
      https://github.com/WebKit/WebKit/commit/c5a93258333f65c7ffdff8de27d429d5e6eff40b
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-10-17 (Thu, 17 Oct 2024)

  Changed paths:
    M Source/WebGPU/WGSL/AttributeValidator.cpp
    M Source/WebGPU/WGSL/Types.cpp
    M Source/WebGPU/WGSL/Types.h
    A Source/WebGPU/WGSL/tests/invalid/required-alignment.wgsl

  Log Message:
  -----------
  [WGSL] shader,validation,shader_io,align:* is failing
https://bugs.webkit.org/show_bug.cgi?id=281588
rdar://135984013

Reviewed by Mike Wyrzykowski.

Add validation for the "required alignment" according to the spec[1], which requires
validating the offset of struct members as well as array strides.

[1]: https://www.w3.org/TR/WGSL/#requiredalignof

* Source/WebGPU/WGSL/AttributeValidator.cpp:
(WGSL::AttributeValidator::visit):
(WGSL::AttributeValidator::validateAlignment):
* Source/WebGPU/WGSL/Types.cpp:
(WGSL::Types::Array::stride const):
* Source/WebGPU/WGSL/Types.h:
* Source/WebGPU/WGSL/tests/invalid/required-alignment.wgsl: Added.

Canonical link: https://commits.webkit.org/285327@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications