[webkit-changes] [WebKit/WebKit] b3dccf: [UnifiedPDF] Add test coverage for 285282 at main

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b3dccfa6e85ad99f2fed991938090991e105a282
      https://github.com/WebKit/WebKit/commit/b3dccfa6e85ad99f2fed991938090991e105a282
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2024-10-17 (Thu, 17 Oct 2024)

  Changed paths:
    M Source/WebCore/plugins/PluginViewBase.h
    M Source/WebCore/testing/Internals.cpp
    M Source/WebCore/testing/Internals.h
    M Source/WebCore/testing/Internals.idl
    M Source/WebKit/WebProcess/Plugins/PluginView.cpp
    M Source/WebKit/WebProcess/Plugins/PluginView.h
    M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
    A Tools/TestWebKitAPI/Tests/WebKit/notEncrypted.pdf
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm

  Log Message:
  -----------
  [UnifiedPDF] Add test coverage for 285282 at main
https://bugs.webkit.org/show_bug.cgi?id=281624
rdar://138064450

Reviewed by Richard Robinson.

This patch adds an API test that exercises the back/forward navigation
flow over an encrypted document, as reported in webkit.org/b/281535
(fixed by 285282 at main).

To achieve this, we also add a testing hook to unlock PDF documents.

* Source/WebCore/plugins/PluginViewBase.h:
(WebCore::PluginViewBase::setPDFDisplayModeForTesting):
  Drive-by fix: No need for the trailing semicolon.
(WebCore::PluginViewBase::unlockPDFDocumentForTesting):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::unlockPDFDocumentForTesting const):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
* Source/WebKit/WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::unlockPDFDocumentForTesting):
* Source/WebKit/WebProcess/Plugins/PluginView.h:
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKit/notEncrypted.pdf: Added.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm:
(TestWebKitAPI::UNIFIED_PDF_TEST):
  New test: UnifiedPDF.PasswordFormShouldDismissAfterNavigation

Canonical link: https://commits.webkit.org/285318@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications