[webkit-changes] [WebKit/WebKit] 5148ca: Make the return type as constexpr for CSSPropertyP...

ziransun noreply at github.com
Wed Oct 16 23:35:44 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5148caa2836b61b2e681e7b81ae0bd54667e9f1a
      https://github.com/WebKit/WebKit/commit/5148caa2836b61b2e681e7b81ae0bd54667e9f1a
  Author: Ziran Sun <zsun at igalia.com>
  Date:   2024-10-16 (Wed, 16 Oct 2024)

  Changed paths:
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+LengthDefinitions.h

  Log Message:
  -----------
  Make the return type as constexpr for CSSPropertyParserHelpers::LengthValidator::isValid().
https://bugs.webkit.org/show_bug.cgi?id=281564

Reviewed by Sam Weinig.

To fix build error for gcc11/12 cases and to be in line with return types in other places.
As stated in the bug we have "call to non-‘constexpr’" error while calling
CSSPropertyParserHelpers::LengthValidator::isValid().
Some relevant restrictions of constextpr have been relaxed at [1] since gcc13.

[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106649

* Source/WebCore/css/parser/CSSPropertyParserConsumer+LengthPercentageDefinitions.h:
(WebCore::CSSPropertyParserHelpers::LengthPercentageValidator::isValid):

Canonical link: https://commits.webkit.org/285315@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list