[webkit-changes] [WebKit/WebKit] 820c41: Adopt -Wunsafe-buffer-usage in WebPageProxy.cpp etc.

geoffreygaren noreply at github.com
Wed Oct 16 13:39:36 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 820c41526f721e4c6dd43200f5353ce204b87e14
      https://github.com/WebKit/WebKit/commit/820c41526f721e4c6dd43200f5353ce204b87e14
  Author: Geoffrey Garen <ggaren at apple.com>
  Date:   2024-10-16 (Wed, 16 Oct 2024)

  Changed paths:
    M Source/WTF/wtf/StdLibExtras.h
    M Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm
    M Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp
    M Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.cpp
    M Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp
    M Source/WebKit/UIProcess/WebPageProxy.cpp

  Log Message:
  -----------
  Adopt -Wunsafe-buffer-usage in WebPageProxy.cpp etc.
https://bugs.webkit.org/show_bug.cgi?id=281591
rdar://138049676

Reviewed by David Kilzer.

Also added some helper functions that should assist future adoption.

I had to use the unsafe helper function in WebRTC because the imported callback
ultimately comes from libwebrtc code we import as a third party library.

* Source/WTF/wtf/StdLibExtras.h:
(WTF::makeSpan):
(WTF::unsafeForgeSpan):
* Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:
(WebKit::LibWebRTCCodecsProxy::createEncoder):
* Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:
(WebKit::WebSWServerToContextConnection::firePushEvent):
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.cpp:
(WebKit::gatherNetworkMap):
(WebKit::isEqual):
(WebKit::sortNetworks):
* Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::setSessionPermissions):
(WebKit::WebAutomationSession::performMouseInteraction):
(WebKit::WebAutomationSession::performInteractionSequence):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::swapToProvisionalPage):

Canonical link: https://commits.webkit.org/285286@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list