[webkit-changes] [WebKit/WebKit] 496ec1: [WGSL] Parser can still stack overflow

Tadeu Zagallo noreply at github.com
Wed Oct 16 05:53:22 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 496ec1f2f2f8248b9ce194bf35f289912f07cdfd
      https://github.com/WebKit/WebKit/commit/496ec1f2f2f8248b9ce194bf35f289912f07cdfd
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-10-16 (Wed, 16 Oct 2024)

  Changed paths:
    A LayoutTests/fast/webgpu/regression/repro_281491-expected.txt
    A LayoutTests/fast/webgpu/regression/repro_281491.html
    M Source/WebGPU/WGSL/Parser.cpp

  Log Message:
  -----------
  [WGSL] Parser can still stack overflow
https://bugs.webkit.org/show_bug.cgi?id=281491
rdar://137684585

Reviewed by Mike Wyrzykowski.

We already have recursion depth checks in the parser, but in some cases it takes
multiple stack frames in a recursion to hit the check, so it's still possible for
it to overflow. To try and remedy add an extra check to try and limit the number
of frames in such recursions.

* Source/WebGPU/WGSL/Parser.cpp:
(WGSL::Parser<Lexer>::parseArgumentExpressionList):

Canonical link: https://commits.webkit.org/285257@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list