[webkit-changes] [WebKit/WebKit] 7f4083: [Navigation] Fix ordering-and-transition/navigate-...

Rob Buis noreply at github.com
Wed Oct 16 01:43:09 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7f408371ac6362b830a6ad6fbe7019d639e2934f
      https://github.com/WebKit/WebKit/commit/7f408371ac6362b830a6ad6fbe7019d639e2934f
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2024-10-16 (Wed, 16 Oct 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/navigation-api/ordering-and-transition/navigate-double-intercept_currententrychange-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/navigation-api/ordering-and-transition/navigate-double-intercept_no-currententrychange-expected.txt
    M Source/WebCore/page/Navigation.cpp
    M Source/WebCore/page/NavigationTransition.cpp
    M Source/WebCore/page/NavigationTransition.h

  Log Message:
  -----------
  [Navigation] Fix ordering-and-transition/navigate-double-intercept.html
https://bugs.webkit.org/show_bug.cgi?id=281448

Reviewed by Alex Christensen.

The ordering-and-transition/navigate-double-intercept.html test uses resources/helpers.js which verifies that transition.finished and AbortSignal
uses the same JS exception object, so adapt the code to do that.

This PR also unskips some tests that cause no problems anymore on mac-wk2-stress.

* LayoutTests/imported/w3c/web-platform-tests/navigation-api/ordering-and-transition/navigate-double-intercept_currententrychange-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/ordering-and-transition/navigate-double-intercept_no-currententrychange-expected.txt:
* Source/WebCore/page/Navigation.cpp:
(WebCore::Navigation::abortOngoingNavigation):
(WebCore::Navigation::innerDispatchNavigateEvent):
* Source/WebCore/page/NavigationTransition.cpp:
(WebCore::NavigationTransition::rejectPromise):
* Source/WebCore/page/NavigationTransition.h:

Canonical link: https://commits.webkit.org/285251@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list