[webkit-changes] [WebKit/WebKit] 09fcd1: [IsDeprecatedWeakRefSmartPointerException] Make We...

Rupin Mittal noreply at github.com
Tue Oct 15 21:55:28 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 09fcd1e009e755c345383b09640e4bc2903bc54e
      https://github.com/WebKit/WebKit/commit/09fcd1e009e755c345383b09640e4bc2903bc54e
  Author: Rupin Mittal <rupin at apple.com>
  Date:   2024-10-15 (Tue, 15 Oct 2024)

  Changed paths:
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebsiteData/WebDeviceOrientationAndMotionAccessController.cpp
    M Source/WebKit/UIProcess/WebsiteData/WebDeviceOrientationAndMotionAccessController.h
    M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
    M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h

  Log Message:
  -----------
  [IsDeprecatedWeakRefSmartPointerException] Make WebDeviceOrientationAndMotionAccessController ref-counted
https://bugs.webkit.org/show_bug.cgi?id=281353
rdar://137781505

Reviewed by Chris Dumez and Geoffrey Garen.

We forward WebDeviceOrientationAndMotionAccessController's ref/deref
to it's owner WebsiteDataStore.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedNavigationActionPolicyDecision):
(WebKit::WebPageProxy::shouldAllowDeviceOrientationAndMotionAccess):
* Source/WebKit/UIProcess/WebsiteData/WebDeviceOrientationAndMotionAccessController.cpp:
(WebKit::WebDeviceOrientationAndMotionAccessController::WebDeviceOrientationAndMotionAccessController):
(WebKit::WebDeviceOrientationAndMotionAccessController::ref const):
(WebKit::WebDeviceOrientationAndMotionAccessController::deref const):
(WebKit::WebDeviceOrientationAndMotionAccessController::clearPermissions): Deleted.
* Source/WebKit/UIProcess/WebsiteData/WebDeviceOrientationAndMotionAccessController.h:
(WebKit::WebDeviceOrientationAndMotionAccessController::clearPermissions):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::WebsiteDataStore):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:
(WebKit::WebsiteDataStore::protectedDeviceOrientationAndMotionAccessController):

Canonical link: https://commits.webkit.org/285242@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list