[webkit-changes] [WebKit/WebKit] 285144: Cherry-pick 283173 at main (0d018b90f374). https://bu...

[Michael Catanzaro]

  Branch: refs/heads/webkitglib/2.46
  Home:   https://github.com/WebKit/WebKit
  Commit: 2851442893cd4b6a9891a1dea20e9d060bd06365
      https://github.com/WebKit/WebKit/commit/2851442893cd4b6a9891a1dea20e9d060bd06365
  Author: Justin Michaud <jmichaud at igalia.com>
  Date:   2024-10-15 (Tue, 15 Oct 2024)

  Changed paths:
    M Source/JavaScriptCore/wasm/WasmBBQJIT32_64.cpp
    M Source/WTF/wtf/Compiler.h

  Log Message:
  -----------
  Cherry-pick 283173 at main (0d018b90f374). https://bugs.webkit.org/show_bug.cgi?id=279039

    Fix ARMv7 clang build
    https://bugs.webkit.org/show_bug.cgi?id=279039

    Reviewed by Yusuke Suzuki.

    This works around some issues with the build when
    using clang.

    Re: tail calls, I am not sure if it is a clang bug
    or if there is some other reason why it is failing
    to make MUST_TAIL_CALL return JSRopeString::resolveToBufferSlow
    a tail call, but it seems safe to disable it for now.

    * Source/JavaScriptCore/wasm/WasmBBQJIT32_64.cpp:
    (JSC::Wasm::BBQJITImpl::BBQJIT::addSIMDLoad):
    (JSC::Wasm::BBQJITImpl::BBQJIT::addSIMDStore):
    (JSC::Wasm::BBQJITImpl::BBQJIT::addSIMDSplat):
    (JSC::Wasm::BBQJITImpl::BBQJIT::addSIMDShuffle):
    (JSC::Wasm::BBQJITImpl::BBQJIT::addSIMDShift):
    (JSC::Wasm::BBQJITImpl::BBQJIT::addSIMDExtmul):
    (JSC::Wasm::BBQJITImpl::BBQJIT::addSIMDLoadSplat):
    (JSC::Wasm::BBQJITImpl::BBQJIT::addSIMDLoadLane):
    (JSC::Wasm::BBQJITImpl::BBQJIT::addSIMDStoreLane):
    (JSC::Wasm::BBQJITImpl::BBQJIT::addSIMDLoadExtend):
    (JSC::Wasm::BBQJITImpl::BBQJIT::addSIMDLoadPad):
    (JSC::Wasm::BBQJITImpl::BBQJIT::addConstant):
    (JSC::Wasm::BBQJITImpl::BBQJIT::addExtractLane):
    (JSC::Wasm::BBQJITImpl::BBQJIT::addReplaceLane):
    (JSC::Wasm::BBQJITImpl::BBQJIT::addSIMDI_V):
    (JSC::Wasm::BBQJITImpl::BBQJIT::addSIMDV_V):
    (JSC::Wasm::BBQJITImpl::BBQJIT::addSIMDBitwiseSelect):
    (JSC::Wasm::BBQJITImpl::BBQJIT::addSIMDRelOp):
    (JSC::Wasm::BBQJITImpl::BBQJIT::addSIMDV_VV):
    (JSC::Wasm::BBQJITImpl::BBQJIT::addSIMDRelaxedFMA):
    * Source/WTF/wtf/Compiler.h:

    Canonical link: https://commits.webkit.org/283173@main

Canonical link: https://commits.webkit.org/282416.212@webkitglib/2.46


  Commit: 33bea1079e80fcbff6208a6b52c027d00c23f95d
      https://github.com/WebKit/WebKit/commit/33bea1079e80fcbff6208a6b52c027d00c23f95d
  Author: Michael Catanzaro <mcatanzaro at redhat.com>
  Date:   2024-10-15 (Tue, 15 Oct 2024)

  Changed paths:
    M Source/ThirdParty/skia/include/private/base/SkFeatures.h
    M Source/ThirdParty/skia/modules/skcms/src/skcms_internals.h
    M Source/ThirdParty/skia/src/core/SkRasterPipeline.h
    M Source/WTF/wtf/Compiler.h

  Log Message:
  -----------
  Build fails on ppc64le due to MUST_TAIL_CALL when tail call is not possible https://bugs.webkit.org/show_bug.cgi?id=279985

Unreviewed 2.46 branch build fix.

Skia's use of the clang::musttail attribute is not supported by Clang on
ppc64le and needs to be removed in Skia. See
https://github.com/llvm/llvm-project/pull/93267 and
https://github.com/llvm/llvm-project/issues/98859 and
https://github.com/llvm/llvm-project/issues/108014 for more info.

These changes are mostly authored by Dan Horák (thank you!).

* Source/ThirdParty/skia/include/private/base/SkFeatures.h:
* Source/ThirdParty/skia/modules/skcms/src/skcms_internals.h:
* Source/ThirdParty/skia/src/core/SkRasterPipeline.h:
* Source/WTF/wtf/Compiler.h:

Canonical link: https://commits.webkit.org/282416.213@webkitglib/2.46


Compare: https://github.com/WebKit/WebKit/compare/7c2cd547e2a9...33bea1079e80

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications