[webkit-changes] [WebKit/WebKit] a38056: [UnifiedPDF] [iOS] FindInPage.FindInUnifiedPDF occ...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a38056878fdb4967e462a643a15a206d89f306ec
      https://github.com/WebKit/WebKit/commit/a38056878fdb4967e462a643a15a206d89f306ec
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2024-10-15 (Tue, 15 Oct 2024)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm

  Log Message:
  -----------
  [UnifiedPDF] [iOS] FindInPage.FindInUnifiedPDF occasionally timing out
https://bugs.webkit.org/show_bug.cgi?id=281485
rdar://137945668

Reviewed by Aditya Keerthi.

FindInPage.FindInUnifiedPDF is flakily timing out, so this patch
speculatively instantiates a TestWKWebView instead of a WKWebView to
perform said test. Empirically, this change has shortened test run
durations, so the hope is that these changes also address flaky
timeouts.

WebKit.WKPDFViewStablePresentationUpdateCallback is given a similar
treatment.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
(TEST(WebKit, FindInUnifiedPDF)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:
(TEST(WebKit, WKPDFViewStablePresentationUpdateCallback)):

Canonical link: https://commits.webkit.org/285211@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications