[webkit-changes] [WebKit/WebKit] 6d27ad: Update serialization for NSParagraphStyle

Simon Lewis noreply at github.com
Mon Oct 14 20:24:09 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6d27ad4515eadd1083bcecda875d94841b977508
      https://github.com/WebKit/WebKit/commit/6d27ad4515eadd1083bcecda875d94841b977508
  Author: Simon Lewis <simon.lewis at apple.com>
  Date:   2024-10-14 (Mon, 14 Oct 2024)

  Changed paths:
    M Source/WTF/wtf/PlatformHave.h
    M Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h
    M Source/WebCore/PAL/pal/spi/mac/NSTextTableSPI.h
    M Source/WebCore/editing/cocoa/AttributedString.h
    M Source/WebCore/editing/cocoa/AttributedString.mm
    M Source/WebCore/platform/ios/wak/WAKAppKitStubs.h
    M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm
    M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm

  Log Message:
  -----------
  Update serialization for NSParagraphStyle
https://bugs.webkit.org/show_bug.cgi?id=280772
rdar://135824523

Reviewed by Wenson Hsieh and Sihui Liu.

This change removes the use of native object serialization for NSParagraphStyle

Covered by existing tests:
- Table border color and thickness tested by WKWebView.AttributedStringFromTable
- NSTextTabs tested by AttributedSubstringForProposedRange.TextAlignmentParagraphStyles

* Source/WTF/wtf/PlatformHave.h:
* Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:
* Source/WebCore/PAL/pal/spi/mac/NSTextTableSPI.h:
* Source/WebCore/editing/cocoa/AttributedString.h:
* Source/WebCore/editing/cocoa/AttributedString.mm:
(WebCore::configureNSTextBlockFromParagraphStyleCommonTableAttributes):
(WebCore::reconstructNSTextAlignment):
(WebCore::reconstructNSTextBlockVerticalAlignment):
(WebCore::reconstructNSTextTableLayoutAlgorithm):
(WebCore::reconstructNSWritingDirection):
(WebCore::reconstructStyle):
(WebCore::toNSObject):
(WebCore::extractParagraphStyleAlignment):
(WebCore::extractTextTableBlockVerticalAlignment):
(WebCore::extractTextTableLayoutAlgorithm):
(WebCore::extractParagraphStyleWritingDirection):
(WebCore::extractParagraphStyle):
(WebCore::extractValue):
(WebCore::extractTableBlockAndTableIDs): Deleted.
* Source/WebCore/platform/ios/wak/WAKAppKitStubs.h:
* Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm:
(IPC::shouldEnableStrictMode):
(IPC::decodeObjectDirectlyRequiringAllowedClasses<NSObject<NSSecureCoding>>):
* Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
(TEST(WKWebView, AttributedStringFromTable)):

Canonical link: https://commits.webkit.org/285172@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list