[webkit-changes] [WebKit/WebKit] e09e4e: REGRESSION(284553 at main): 2x TestWebKitAPI.IPCTesti...

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e09e4edf3a0398b822adf4091ec71cf69c6f71d1
      https://github.com/WebKit/WebKit/commit/e09e4edf3a0398b822adf4091ec71cf69c6f71d1
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2024-10-14 (Mon, 14 Oct 2024)

  Changed paths:
    M Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm

  Log Message:
  -----------
  REGRESSION(284553 at main): 2x TestWebKitAPI.IPCTestingAPI (API-Tests) are constant failures.
https://bugs.webkit.org/show_bug.cgi?id=280833
<rdar://137215517>

Reviewed by Simon Fraser.

284553 at main changed the error message string, so update
CanSendInvalidSyncMessageToUIProcessWithoutTermination to look for the right
one.

It also made IPC::Decoder's constructor implicitly decode the SyncRequestID, so
make testing code use that value instead of decoding it a second time (which
incorrectly advances the iterator).

* Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp:
(WebKit::IPCTestingAPI::JSMessageListener::jsDescriptionFromDecoder):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm:
(TEST(IPCTestingAPI, CanSendInvalidSyncMessageToUIProcessWithoutTermination)):
(CanInterceptAlert)):
(TEST(IPCTestingAPI, DISABLED_CanSendInvalidSyncMessageToUIProcessWithoutTermination)): Deleted.
(DISABLED_CanInterceptAlert)): Deleted.

Canonical link: https://commits.webkit.org/285169@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications