[webkit-changes] [WebKit/WebKit] d146f3: Disable iPad Mini UA overrides when Site Specific ...

[Brent Fulgham]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d146f360321a12c140eb7278b3d173900d44fcb8
      https://github.com/WebKit/WebKit/commit/d146f360321a12c140eb7278b3d173900d44fcb8
  Author: Brent Fulgham <bfulgham at apple.com>
  Date:   2024-10-14 (Mon, 14 Oct 2024)

  Changed paths:
    M Source/WTF/Scripts/GeneratePreferences.rb
    M Source/WebCore/inspector/InspectorClient.h
    M Source/WebCore/inspector/agents/InspectorPageAgent.cpp
    M Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesDefinitions.h.erb
    M Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesGetterSetters.cpp.erb
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
    M Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.cpp
    M Source/WebKit/UIProcess/WebPreferences.h
    M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm

  Log Message:
  -----------
  Disable iPad Mini UA overrides when Site Specific Hacks are disabled
https://bugs.webkit.org/show_bug.cgi?id=281212
rdar://50035167

Reviewed by Devin Rousso and Patrick Angle.

iPad Mini UA overrides needs to be disabled when Site Specific Hacks
are disabled.

Karl's work on that issue revealed that changing the Site Specific Quirks
state through the WebInspector did not trigger a notification in the UIProcess.
Since the UIProcess governs the load, quirks about using Desktop versus
Mobile state were not disabled.

This patch fixes both issues.

It also updates the generated preferences to use an optional override value
when appropriate, similar to how the WebCore's Settings overrides work. This
will allow the page to snap back to default behavior when the WebInspector
is disconnected.

* Source/WTF/Scripts/GeneratePreferences.rb:
* Source/WebCore/inspector/InspectorClient.h:
* Source/WebCore/inspector/agents/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::overrideSetting):
* Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesDefinitions.h.erb:
* Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesGetterSetters.cpp.erb:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.cpp:
(WebKit::WebInspectorUIProxy::setDeveloperPreferenceOverride):
* Source/WebKit/UIProcess/WebPreferences.h:
* Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::isDesktopClassBrowsingRecommended const):

Canonical link: https://commits.webkit.org/285166@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications