[webkit-changes] [WebKit/WebKit] b37bf8: REGRESSION: ASSERTION FAILED: repaintRects() in We...

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b37bf876c9b79cfe225c7858c23e58e8a2cd43e6
      https://github.com/WebKit/WebKit/commit/b37bf876c9b79cfe225c7858c23e58e8a2cd43e6
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2024-10-14 (Mon, 14 Oct 2024)

  Changed paths:
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/platform/win/TestExpectations
    M Source/WebCore/rendering/RenderLayer.cpp
    M Source/WebCore/rendering/style/RenderStyle.h
    M Source/WebCore/rendering/style/RenderStyleInlines.h
    M Source/WebCore/rendering/style/StyleMiscNonInheritedData.h

  Log Message:
  -----------
  REGRESSION: ASSERTION FAILED: repaintRects() in WebCore::RenderLayer::recursiveUpdateLayerPositions.
https://bugs.webkit.org/show_bug.cgi?id=281041
<rdar://137722495>

Reviewed by Simon Fraser.

The presence of repaintRects now depends on isVisibilityHiddenOrOpacityZero(),
not just hasVisibleContent.  Make sure we invalidate layer positions for opacity
changes, and change the logging to be the value that we care about.

Also switches the layer assertions to preferentially use debug asserts, so that
they are in use more often.

* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects const):
(WebCore::outputLayerPositionTreeLegend):
(WebCore::outputLayerPositionTreeRecursive):

Canonical link: https://commits.webkit.org/285155@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications