[webkit-changes] [WebKit/WebKit] 283687: gmail.com: [iPad] Tapping the file icon when compo...

[Jessica Cheung]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 283687c657f3eee714f2918de62129ee15bda3b6
      https://github.com/WebKit/WebKit/commit/283687c657f3eee714f2918de62129ee15bda3b6
  Author: Jessica Cheung <jcheung23 at apple.com>
  Date:   2024-10-14 (Mon, 14 Oct 2024)

  Changed paths:
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
    M Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.h
    M Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm

  Log Message:
  -----------
  gmail.com: [iPad] Tapping the file icon when composing an email brings up the keyboard
https://bugs.webkit.org/show_bug.cgi?id=281194
rdar://89692326

Reviewed by Wenson Hsieh.

Changed `WKContentViewInteraction.mm` to check for repositioning context menu
when keyboard is dismissed. If keyboard is dismissed, we should reposition back
to the bottom where it would be without a keyboard shown.
Fixed positioning of context menu when file icon is clicked in gmail.com [iPad]
so when keyboard is up, we don't cover the context menu.

* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _keyboardDidShow]):
(-[WKContentView _keyboardDidRequestDismissal:]):
* Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.h:
* Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm:
(-[WKFileUploadPanel presentWithParameters:resultListener:]):

Canonical link: https://commits.webkit.org/285153@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications