[webkit-changes] [WebKit/WebKit] 0b69c4: [scroll-animations] Implement parsing support for ...

[Nikos Mouchtaris]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0b69c4397a4c4be00d3ede312efc7a0a9ab3aeba
      https://github.com/WebKit/WebKit/commit/0b69c4397a4c4be00d3ede312efc7a0a9ab3aeba
  Author: Nikolaos Mouchtaris <nmouchtaris at apple.com>
  Date:   2024-10-14 (Mon, 14 Oct 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-range-end-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-range-end-invalid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-range-end-invalid.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-range-end-valid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-range-shorthand-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-range-shorthand.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-range-start-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-range-start-invalid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-range-start-invalid.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-range-start-valid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-shorthand-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-shorthand-expected.txt
    M LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt
    M Source/WebCore/Headers.cmake
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/animation/CSSPropertyAnimation.cpp
    A Source/WebCore/animation/TimelineRange.cpp
    M Source/WebCore/animation/TimelineRange.h
    M Source/WebCore/animation/TimelineRangeOffset.h
    M Source/WebCore/animation/WebAnimation.h
    M Source/WebCore/animation/WebAnimationTypes.h
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/css/CSSValueKeywords.in
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/css/ShorthandSerializer.cpp
    M Source/WebCore/css/parser/CSSPropertyParser.cpp
    M Source/WebCore/css/parser/CSSPropertyParser.h
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+Timeline.cpp
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+Timeline.h
    M Source/WebCore/rendering/style/RenderStyle.h
    M Source/WebCore/rendering/style/RenderStyleInlines.h
    M Source/WebCore/rendering/style/RenderStyleSetters.h
    M Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp
    M Source/WebCore/rendering/style/StyleRareNonInheritedData.h
    M Source/WebCore/style/StyleBuilderConverter.h

  Log Message:
  -----------
  [scroll-animations] Implement parsing support for animation-range and its longhand properties
https://bugs.webkit.org/show_bug.cgi?id=280862
rdar://137717240

Reviewed by Tim Nguyen and Darin Adler.

Implement parsing support for animation-range and its longhand properties. This needs a follow up
for sequences of animation ranges. There is also a failing subtest about determining if a calc
expression is a default offset value that needs some thought.

* Source/WebCore/Headers.cmake:
* Source/WebCore/animation/AnimationTimeline.h:
(WebCore::SingleTimelineRange::operator== const):
* Source/WebCore/animation/TimelineRangeOffset.h:
(WebCore::TimelineRangeOffset::operator== const):
* Source/WebCore/animation/WebAnimationTypes.h:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::valueForAnimationRange):
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle const):
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Timeline.cpp:
(WebCore::CSSPropertyParserHelpers::consumeAnimationRange):
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Timeline.h:
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleInlines.h:
(WebCore::RenderStyle::initialAnimationRangeStart):
(WebCore::RenderStyle::initialAnimationRangeEnd):
(WebCore::RenderStyle::animationRangeStart const):
(WebCore::RenderStyle::animationRangeEnd const):
* Source/WebCore/rendering/style/RenderStyleSetters.h:
(WebCore::RenderStyle::setAnimationRangeStart):
(WebCore::RenderStyle::setAnimationRangeEnd):
* Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator== const):
* Source/WebCore/rendering/style/StyleRareNonInheritedData.h:
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertAnimationRangeStart):
(WebCore::Style::BuilderConverter::convertAnimationRangeEnd):
(WebCore::Style::BuilderConverter::convertAnimationRange):

Canonical link: https://commits.webkit.org/285135@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications