[webkit-changes] [WebKit/WebKit] d7cae8: [scroll-animations] Update view timeline progress ...

[Nikos Mouchtaris]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d7cae82b7c21b6b64e56ffb8ba43c0e8bb1a0ba2
      https://github.com/WebKit/WebKit/commit/d7cae82b7c21b6b64e56ffb8ba43c0e8bb1a0ba2
  Author: Nikolaos Mouchtaris <nmouchtaris at apple.com>
  Date:   2024-10-14 (Mon, 14 Oct 2024)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/intermediate-transform-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/intermediate-transform.html
    M Source/WebCore/animation/ViewTimeline.cpp
    M Source/WebCore/animation/ViewTimeline.h

  Log Message:
  -----------
  [scroll-animations] Update view timeline progress calculation to use localToContainerPoint for subject offset calculation
https://bugs.webkit.org/show_bug.cgi?id=281259
rdar://137715213

Reviewed by Simon Fraser.

Update view timeline progress calculation to use localToContainerPoint for subject offset calculation, as offsetTop doesn't
calculate the offset from the source, but from the offsetParent. Also add a simple test to ensure that intermediate transformations
are taken into account.

* LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-range-shorthand.html:
* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/intermediate-transform-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/intermediate-transform.html: Added.
* Source/WebCore/animation/ViewTimeline.cpp:
(WebCore::ViewTimeline::ViewTimeline):
(WebCore::ViewTimeline::source const):
(WebCore::ViewTimeline::sourceScrollerRenderer const):
(WebCore::ViewTimeline::computeTimelineData const):
(WebCore::ViewTimeline::startOffset):
(WebCore::ViewTimeline::endOffset):
(WebCore::ViewTimeline::sourceRenderer const): Deleted.
(WebCore::ViewTimeline::startOffset const): Deleted.
(WebCore::ViewTimeline::endOffset const): Deleted.
* Source/WebCore/animation/ViewTimeline.h:

Canonical link: https://commits.webkit.org/285132@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications