[webkit-changes] [WebKit/WebKit] 48e051: Change the StringBuilder in stringReplaceAllString...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 48e051485568bf5a206d50a450a002f9a640bd96
      https://github.com/WebKit/WebKit/commit/48e051485568bf5a206d50a450a002f9a640bd96
  Author: Mark Lam <mark.lam at apple.com>
  Date:   2024-10-14 (Mon, 14 Oct 2024)

  Changed paths:
    A JSTests/stress/string-replaceAll-string-string-overflow.js
    M Source/JavaScriptCore/runtime/StringPrototypeInlines.h

  Log Message:
  -----------
  Change the StringBuilder in stringReplaceAllStringString to RecordOverflow.
https://bugs.webkit.org/show_bug.cgi?id=281412
rdar://137230737

Reviewed by Yijia Huang.

The function was already checking for resultBuilder.hasOverflowed(), but without this
RecordOverflow handler being explicitly specified, the StringBuilder will crash eagerly
on detected overflow.

* JSTests/stress/string-replaceAll-string-string-overflow.js: Added.
(catch):
* Source/JavaScriptCore/runtime/StringPrototypeInlines.h:
(JSC::stringReplaceAllStringString):

Canonical link: https://commits.webkit.org/285126@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications