[webkit-changes] [WebKit/WebKit] 04d86f: Build fixes for !ENABLE(VIDEO)

Olivier Blin noreply at github.com
Mon Oct 14 01:42:13 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 04d86ff06087386303ee8ab3dc0d07173fff1dfb
      https://github.com/WebKit/WebKit/commit/04d86ff06087386303ee8ab3dc0d07173fff1dfb
  Author: Olivier Blin <olivier.blin at softathome.com>
  Date:   2024-10-14 (Mon, 14 Oct 2024)

  Changed paths:
    M Source/WebCore/Modules/WebGPU/GPUDevice.h
    M Source/WebCore/css/CSSPseudoSelectors.json
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/FullscreenManager.cpp
    M Source/WebCore/page/DiagnosticLoggingKeys.cpp
    M Source/WebCore/page/DiagnosticLoggingKeys.h
    M Source/WebCore/page/ElementTargetingController.cpp
    M Source/WebCore/rendering/updating/RenderTreeBuilder.cpp
    M Source/WebCore/testing/Internals.cpp
    M Source/WebCore/testing/Internals.h
    M Source/WebCore/testing/Internals.idl
    M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp
    M Source/WebKit/WebProcess/GPU/media/gstreamer/VideoLayerRemoteGStreamer.cpp

  Log Message:
  -----------
  Build fixes for !ENABLE(VIDEO)
https://bugs.webkit.org/show_bug.cgi?id=281253

Reviewed by Philippe Normand.

* Source/WebCore/Modules/WebGPU/GPUDevice.h:
    Flag variables only used with ENABLE(VIDEO)
        m_videoElementToExternalTextureMap
        m_previouslyImportedExternalTexture
        m_lastCreatedExternalTextureBindGroup

* Source/WebCore/css/CSSPseudoSelectors.json:
    Flag -internal-in-window-fullscreen to avoid warning in SelectorChecker switch

* Source/WebCore/dom/Document.cpp:
(WebCore::eventTargetElementForDocument):
    Flag HTMLVideoElement check

* Source/WebCore/dom/FullscreenManager.cpp:
(WebCore::FullscreenManager::willEnterFullscreen):
    Fix unused variable warning

* Source/WebCore/page/DiagnosticLoggingKeys.cpp:
(WebCore::DiagnosticLoggingKeys::mediaElementSourceTypeDiagnosticLoggingKey): Deleted.
* Source/WebCore/page/DiagnosticLoggingKeys.h:
    Remove unused mediaElementSourceTypeDiagnosticLoggingKey after 282029 at main

* Source/WebCore/page/ElementTargetingController.cpp:
(WebCore::hasAudibleMedia):
(WebCore::urlForElement):
    Flag HTMLMediaElement usage

* Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::attachToRenderElementInternal):
    Flag RenderVideo check

* Source/WebCore/testing/Internals.cpp:
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
    Make isEffectivelyMuted conditional since it uses HTMLMediaElement

* Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::didClose):
    m_remoteMediaResourceManager is defined only with ENABLE(VIDEO)

* Source/WebKit/WebProcess/GPU/media/gstreamer/VideoLayerRemoteGStreamer.cpp:
    Flag the whole file under ENABLE(VIDEO) like other media GPU Process files

Canonical link: https://commits.webkit.org/285114@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list