[webkit-changes] [WebKit/WebKit] 990f8c: Popover non-modal dialog blocks interaction on con...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 990f8c4b4cc0cef73a7c69c82f4ea59b03e1028f
      https://github.com/WebKit/WebKit/commit/990f8c4b4cc0cef73a7c69c82f4ea59b03e1028f
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-10-13 (Sun, 13 Oct 2024)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/popover-dialog-does-not-block-mouse-events-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/popover-dialog-does-not-block-mouse-events.html
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-expected.txt
    M LayoutTests/platform/ios/TestExpectations
    M LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-expected.txt
    M Source/WebCore/dom/Document.cpp

  Log Message:
  -----------
  Popover non-modal dialog blocks interaction on content behind it
https://bugs.webkit.org/show_bug.cgi?id=280940
rdar://137809195

Reviewed by Simon Fraser.

Now that both popovers and dialogs can be in the top layer (and dialogs can also be popovers), `Document::activeModalDialog()` needs to check whether
the dialog is a modal dialog (and not a popover dialog). This function also determines whether the content behind the dialog gets turned inert.

* LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/popover-dialog-does-not-block-mouse-events-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/popover-dialog-does-not-block-mouse-events.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-expected.txt:
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-expected.txt:
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::activeModalDialog const):

Canonical link: https://commits.webkit.org/285103@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications