[webkit-changes] [WebKit/WebKit] 9a99e1: [FFC][Integration] Construct BoxGeometry for out-o...

Alan Baradlay noreply at github.com
Sun Oct 13 12:37:52 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9a99e1b9aa2732386ca34fd3758bdce32cbb49b1
      https://github.com/WebKit/WebKit/commit/9a99e1b9aa2732386ca34fd3758bdce32cbb49b1
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-10-13 (Sun, 13 Oct 2024)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h
    M Source/WebCore/layout/integration/LayoutIntegrationBoxGeometryUpdater.cpp
    M Source/WebCore/layout/layouttree/LayoutBox.cpp
    M Source/WebCore/layout/layouttree/LayoutBox.h
    M Source/WebCore/layout/layouttree/LayoutElementBox.cpp
    M Source/WebCore/layout/layouttree/LayoutElementBox.h

  Log Message:
  -----------
  [FFC][Integration] Construct BoxGeometry for out-of-flow (non-flex item) children
https://bugs.webkit.org/show_bug.cgi?id=281323

Reviewed by Antti Koivisto.

While out-of-flow positioning in flex is not yet supported, this allows us to run
tests with out-of-flow boxes without crashing in release.

* Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::layout):
(WebCore::Layout::FlexFormattingContext::positionOutOfFlowChildren):
* Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h:
* Source/WebCore/layout/integration/LayoutIntegrationBoxGeometryUpdater.cpp:
(WebCore::LayoutIntegration::BoxGeometryUpdater::setFormattingContextContentGeometry):
* Source/WebCore/layout/layouttree/LayoutBox.cpp:
(WebCore::Layout::Box::nextOutOfFlowSibling const):
(WebCore::Layout::Box::previousOutOfFlowSibling const):
* Source/WebCore/layout/layouttree/LayoutBox.h:
* Source/WebCore/layout/layouttree/LayoutElementBox.cpp:
(WebCore::Layout::ElementBox::firstOutOfFlowChild const):
(WebCore::Layout::ElementBox::lastOutOfFlowChild const):
(WebCore::Layout::ElementBox::hasOutOfFlowChild const):
* Source/WebCore/layout/layouttree/LayoutElementBox.h:

Canonical link: https://commits.webkit.org/285096@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list