[webkit-changes] [WebKit/WebKit] da8a30: [UnifiedPDF] WKWebView.IsDisplayingPDF API test is...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: da8a3074bc9b4622fdf88144ea20729beaa5363c
      https://github.com/WebKit/WebKit/commit/da8a3074bc9b4622fdf88144ea20729beaa5363c
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2024-10-13 (Sun, 13 Oct 2024)

  Changed paths:
    M Tools/TestWebKitAPI/SourcesCocoa.txt
    M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTestHelpers.h
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTestHelpers.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPreferences.mm

  Log Message:
  -----------
  [UnifiedPDF] WKWebView.IsDisplayingPDF API test is duplicated
https://bugs.webkit.org/show_bug.cgi?id=281358
rdar://137786080

Reviewed by Wenson Hsieh.

This API test is duplicated, defined once in WKWebView.IsDisplayingPDF
and again in UnifiedPDF.WKWebView_IsDisplayingPDF, with the only
difference being that the latter flips the Unified PDF feature. This
patch consolidates the two test definitions.

To facilitate this change, we move out some UnifiedPDF-related test
utilities out into its own translation unit. We re-use these utilities
in FindInPage.mm, UnifiedPDFTests.mm, and WKPDFView.mm.

* Tools/TestWebKitAPI/SourcesCocoa.txt:
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Drive-by fix: WebGLPolicy.mm does not exist in the tree anymore.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
(TEST(WebKit, FindInUnifiedPDF)):
(TEST(WebKit, FindInUnifiedPDFAfterReload)):
(TEST(WebKit, FindInUnifiedPDFAfterFindInPage)):
(configurationForWebViewTestingFindInUnifiedPDF): Deleted.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTestHelpers.h: Added.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTestHelpers.mm: Added.
(TestWebKitAPI::configurationForWebViewTestingUnifiedPDF):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm:
(TestWebKitAPI::configurationForWebViewTestingUnifiedPDF): Deleted.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:
(TEST(WKWebView, IsDisplayingPDF)):

* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPreferences.mm:

Drive-by fix: Unified sources.
Canonical link: https://commits.webkit.org/285092@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications