[webkit-changes] [WebKit/WebKit] 20ddf9: AX: Remove unnecessary AccessibilityRole::{RubyBas...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 20ddf93b7b09de3a0852d49dd036ad2da1d19eb7
      https://github.com/WebKit/WebKit/commit/20ddf93b7b09de3a0852d49dd036ad2da1d19eb7
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2024-10-12 (Sat, 12 Oct 2024)

  Changed paths:
    M LayoutTests/accessibility/mac/ruby-hierarchy-roles-expected.txt
    M LayoutTests/accessibility/mac/ruby-hierarchy-roles.html
    M Source/WebCore/accessibility/AXCoreObject.h
    M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
    M Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp
    M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
    M Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm

  Log Message:
  -----------
  AX: Remove unnecessary AccessibilityRole::{RubyBase, RubyBlock, RubyRun} and simplify accessibility/mac/ruby-hierarchy-roles.html
https://bugs.webkit.org/show_bug.cgi?id=281356
rdar://137784243

Reviewed by Chris Fleizach.

This patch removes AccessibilityRole::{RubyBase, RubyBlock, RubyRun}, as the subrole they map to is not used by
any Apple assistive technology, and are not mapped in https://w3c.github.io/html-aam/.

AccessibilityRole::RubyInline (mapping to AXSubrole: AXRubyInline) and AccessibilityRole::RubyText (mapping to AXSubrole: AXRubyText)
are present and mapped in https://w3c.github.io/html-aam, so this patch does not remove them, even though they are also
not actually used by any Apple assistive technology at the time of this writing.

This patch also modernizes accessibility/mac/ruby-hierarchy-roles.html and removes the conditions that tested for the
removed subroles.

* LayoutTests/accessibility/mac/ruby-hierarchy-roles-expected.txt:
* LayoutTests/accessibility/mac/ruby-hierarchy-roles.html:
* Source/WebCore/accessibility/AXCoreObject.h:
(WebCore::accessibilityRoleToString):
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):
* Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::subrolePlatformString const):
(WebCore::Accessibility::createPlatformRoleMap):

Canonical link: https://commits.webkit.org/285072@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications