[webkit-changes] [WebKit/WebKit] 618be9: Fix `scriptlevel` multipler (font-size)

Ahmad Saleem noreply at github.com
Sat Oct 12 04:30:23 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 618be985f329c157b17c026c39fc67fa47f8849b
      https://github.com/WebKit/WebKit/commit/618be985f329c157b17c026c39fc67fa47f8849b
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2024-10-12 (Sat, 12 Oct 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/width-height-001-expected.txt
    M LayoutTests/mathml/presentation/scripts-subsup.html
    M LayoutTests/mathml/presentation/scripts-underover.html
    M LayoutTests/mathml/presentation/underover-nonstretchy-or-vertical.html
    M LayoutTests/platform/glib/accessibility/math-multiscript-attributes-expected.txt
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/scriptlevel-001-expected.txt
    M LayoutTests/platform/glib/mathml/opentype/horizontal-expected.txt
    M LayoutTests/platform/glib/mathml/opentype/horizontal-munderover-expected.txt
    M LayoutTests/platform/glib/mathml/opentype/opentype-stretchy-horizontal-expected.txt
    M LayoutTests/platform/glib/mathml/presentation/bug159513-expected.txt
    M LayoutTests/platform/ios/imported/w3c/web-platform-tests/mathml/relations/css-styling/scriptlevel-001-expected.txt
    M LayoutTests/platform/ios/imported/w3c/web-platform-tests/mathml/relations/css-styling/size-containment-001.tentative-expected.txt
    M LayoutTests/platform/ios/mathml/opentype/opentype-stretchy-horizontal-expected.txt
    M LayoutTests/platform/mac/accessibility/math-multiscript-attributes-expected.txt
    M LayoutTests/platform/mac/imported/w3c/web-platform-tests/mathml/relations/css-styling/scriptlevel-001-expected.txt
    M LayoutTests/platform/mac/imported/w3c/web-platform-tests/mathml/relations/css-styling/size-containment-001.tentative-expected.txt
    M LayoutTests/platform/mac/mathml/opentype/opentype-stretchy-horizontal-expected.txt
    M Source/WebCore/css/mathml.css

  Log Message:
  -----------
  Fix `scriptlevel` multipler (font-size)
https://bugs.webkit.org/show_bug.cgi?id=281220
rdar://137671252

Reviewed by Frédéric Wang.

The following is not defined in MathML Core specification [1] because
it has `font-size: math`, which WebKit don't implement yet and this
works as fallback (when the font has no math table).

[1] https://w3c.github.io/mathml-core/#user-agent-stylesheet

This patch is to align with old specification [2] of `scriptsizemultiplier`,
which was incorrect in our current implementation.

[2] https://www.w3.org/TR/REC-MathML/chap3_3.html (Refer: Attributes accepted by <mstyle>)

It is also referred as `scriptPercentScaleDown` and `scriptScriptPercentScaleDown` as
Layout Constants in MathML Core [3].

[3] https://w3c.github.io/mathml-core/#layout-constants-mathconstants

* LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/width-height-001-expected.txt:
* LayoutTests/mathml/presentation/scripts-subsup.html:
* LayoutTests/mathml/presentation/scripts-underover.html:
* LayoutTests/mathml/presentation/underover-nonstretchy-or-vertical.html:
* LayoutTests/platform/glib/accessibility/math-multiscript-attributes-expected.txt:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/scriptlevel-001-expected.txt:
* LayoutTests/platform/glib/mathml/opentype/horizontal-expected.txt:
* LayoutTests/platform/glib/mathml/opentype/horizontal-munderover-expected.txt:
* LayoutTests/platform/glib/mathml/opentype/opentype-stretchy-horizontal-expected.txt:
* LayoutTests/platform/glib/mathml/presentation/bug159513-expected.txt:
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/mathml/relations/css-styling/scriptlevel-001-expected.txt:
* LayoutTests/platform/ios/mathml/opentype/opentype-stretchy-horizontal-expected.txt:
* LayoutTests/platform/mac/accessibility/math-multiscript-attributes-expected.txt:
* LayoutTests/platform/mac/imported/w3c/web-platform-tests/mathml/relations/css-styling/scriptlevel-001-expected.txt:
* LayoutTests/platform/mac/imported/w3c/web-platform-tests/mathml/relations/css-styling/size-containment-001.tentative-expected.txt:
* LayoutTests/platform/mac/mathml/opentype/opentype-stretchy-horizontal-expected.txt:
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/mathml/relations/css-styling/size-containment-001.tentative-expected.txt
* Source/WebCore/css/mathml.css:
(msub > * + *, msup > * + *, msubsup > * + *, mmultiscripts > * + *, munder > * + *, mover > * + *, munderover > * + *):
(mroot > *:last-child):

Canonical link: https://commits.webkit.org/285069@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list