[webkit-changes] [WebKit/WebKit] be3c0c: Add lock icon on HTTPS browsing warning page

Commit Queue noreply at github.com
Fri Oct 11 16:11:43 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: be3c0c9a661fa4990b468ee62eb4784390a24ebc
      https://github.com/WebKit/WebKit/commit/be3c0c9a661fa4990b468ee62eb4784390a24ebc
  Author: Matthew Finkel <m_finkel at apple.com>
  Date:   2024-10-11 (Fri, 11 Oct 2024)

  Changed paths:
    M Source/WebKit/UIProcess/Cocoa/_WKWarningView.mm

  Log Message:
  -----------
  Add lock icon on HTTPS browsing warning page
https://bugs.webkit.org/show_bug.cgi?id=280732
rdar://133800121

Reviewed by Aditya Keerthi.

Use the SF Symbols lock.slash icon on the HTTPSOnly browsing warning page,
instead of reusing the exclamation point from the SafeBrowsing page. This
change also replaces the existing exclamation mark with the SF symbol.

This change also has a small drive-by fix for the colors used on non-macOS.

* Source/WebKit/UIProcess/Cocoa/_WKWarningView.mm:
(colorForItem):
(viewForIconImage):
(-[_WKWarningView addContent]):
(-[WKSafeBrowsingExclamationPoint drawRect:]): Deleted.
(-[WKSafeBrowsingExclamationPoint viewDidChangeEffectiveAppearance]): Deleted.
(-[WKSafeBrowsingExclamationPoint intrinsicContentSize]): Deleted.

Canonical link: https://commits.webkit.org/285045@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list