[webkit-changes] [WebKit/WebKit] 5aed44: [css-view-transitions] Implement 'auto' value for ...

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5aed448416d432a624ec51b3a77fafc418f6683d
      https://github.com/WebKit/WebKit/commit/5aed448416d432a624ec51b3a77fafc418f6683d
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2024-10-11 (Fri, 11 Oct 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/parsing/view-transition-name-valid-expected.txt
    M Source/WebCore/Headers.cmake
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/animation/CSSPropertyAnimation.cpp
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+ViewTransition.cpp
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+ViewTransition.h
    M Source/WebCore/dom/ViewTransition.cpp
    M Source/WebCore/dom/ViewTransition.h
    M Source/WebCore/rendering/RenderElement.cpp
    M Source/WebCore/rendering/style/RenderStyle.h
    M Source/WebCore/rendering/style/RenderStyleInlines.h
    M Source/WebCore/rendering/style/RenderStyleSetters.h
    M Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp
    M Source/WebCore/rendering/style/StyleRareNonInheritedData.h
    A Source/WebCore/rendering/style/ViewTransitionName.h
    M Source/WebCore/style/StyleAdjuster.cpp
    M Source/WebCore/style/StyleBuilderConverter.h

  Log Message:
  -----------
  [css-view-transitions] Implement 'auto' value for view-transition-name.
https://bugs.webkit.org/show_bug.cgi?id=281203
<rdar://137656730>

Reviewed by Tim Nguyen.

Support the 'auto' value by using the Element's ID if available, otherwise a generated string.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/parsing/view-transition-name-valid-expected.txt:
* Source/WebCore/Headers.cmake:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle const):
* Source/WebCore/css/parser/CSSPropertyParserConsumer+ViewTransition.cpp:
(WebCore::CSSPropertyParserHelpers::consumeViewTransitionName): Deleted.
* Source/WebCore/css/parser/CSSPropertyParserConsumer+ViewTransition.h:
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::effectiveViewTransitionName):
(WebCore::ViewTransition::captureOldState):
(WebCore::ViewTransition::captureNewState):
* Source/WebCore/dom/ViewTransition.h:
(WebCore::ViewTransition::isCrossDocument):
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::hasViewTransitionName const):
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleInlines.h:
(WebCore::RenderStyle::initialViewTransitionName):
(WebCore::RenderStyle::viewTransitionName const):
* Source/WebCore/rendering/style/RenderStyleSetters.h:
(WebCore::RenderStyle::setViewTransitionName):
* Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
* Source/WebCore/rendering/style/StyleRareNonInheritedData.h:
* Source/WebCore/rendering/style/ViewTransitionName.h: Added.
(WebCore::ViewTransitionName::createWithNone):
(WebCore::ViewTransitionName::createWithAuto):
(WebCore::ViewTransitionName::createWithCustomIdent):
(WebCore::ViewTransitionName::isNone const):
(WebCore::ViewTransitionName::isAuto const):
(WebCore::ViewTransitionName::isCustomIdent const):
(WebCore::ViewTransitionName::customIdent const):
(WebCore::ViewTransitionName::scopeOrdinal const):
(WebCore::ViewTransitionName::ViewTransitionName):
(WebCore::operator<<):
* Source/WebCore/style/StyleAdjuster.cpp:
(WebCore::Style::Adjuster::adjust const):
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertViewTransitionName):

Canonical link: https://commits.webkit.org/285041@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications