[webkit-changes] [WebKit/WebKit] b076ef: [WPE] REGRESSION(284269 at main): Inspector crashes d...

Adrian Perez noreply at github.com
Fri Oct 11 13:42:56 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b076eff3f70e46ae846783f7f0dc9d3bf598a763
      https://github.com/WebKit/WebKit/commit/b076eff3f70e46ae846783f7f0dc9d3bf598a763
  Author: Adrian Perez de Castro <aperez at igalia.com>
  Date:   2024-10-11 (Fri, 11 Oct 2024)

  Changed paths:
    M Source/WTF/wtf/glib/GRefPtr.cpp
    M Source/WTF/wtf/glib/GRefPtr.h
    M Source/WTF/wtf/glib/GTypedefs.h

  Log Message:
  -----------
  [WPE] REGRESSION(284269 at main): Inspector crashes due to missing GRefPtr specialization for GResource
https://bugs.webkit.org/show_bug.cgi?id=281298

Reviewed by Michael Catanzaro.

Add template specializations to make GRefPtr<GResource> use g_resource_{ref,unref}.
This is needed because GResource is not a GObject subclass, therefore using the
generic implementation of the template picked g_object_{ref,unref} instead and
the internal GLib sanity checks failed.

* Source/WTF/wtf/glib/GRefPtr.cpp:
(WTF::refGPtr): Added specialization for GResource.
(WTF::derefGPtr): Ditto.
* Source/WTF/wtf/glib/GRefPtr.h: Add template specialization declarations.
* Source/WTF/wtf/glib/GTypedefs.h: Add forward-declaration for GResource.

Canonical link: https://commits.webkit.org/285035@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list