[webkit-changes] [WebKit/WebKit] 6f2722: Fix TestWebKitAPI.SiteIsolation.RunOpenPanel

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6f27221175db7b06277d9a4cb310d9d938e2f9de
      https://github.com/WebKit/WebKit/commit/6f27221175db7b06277d9a4cb310d9d938e2f9de
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-10-11 (Fri, 11 Oct 2024)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm

  Log Message:
  -----------
  Fix TestWebKitAPI.SiteIsolation.RunOpenPanel
https://bugs.webkit.org/show_bug.cgi?id=281276
rdar://137267779

Reviewed by Wenson Hsieh.

It was flaky because of the async nature of WebPageProxy::didChooseFilesForOpenPanel.
It was possible for the evaulateJavaScript message to be received by the web content process
before the WebPage::DidChooseFilesForOpenPanel message.  This makes it so if that happens,
we will just cleanly try again.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST(SiteIsolation, RunOpenPanel)):
(TestWebKitAPI::TEST(SiteIsolation, DISABLED_RunOpenPanel)): Deleted.

Canonical link: https://commits.webkit.org/285026@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications