[webkit-changes] [WebKit/WebKit] dd6e6d: [Tools][GTK][WPE] generate-bundle: Improve the uni...

[Carlos Alberto Lopez Perez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dd6e6dfb40ef4141ea4145957aa08984bff5c77c
      https://github.com/WebKit/WebKit/commit/dd6e6dfb40ef4141ea4145957aa08984bff5c77c
  Author: Carlos Alberto Lopez Perez <clopez at igalia.com>
  Date:   2024-10-11 (Fri, 11 Oct 2024)

  Changed paths:
    M Tools/Scripts/generate-bundle
    M Tools/Scripts/webkitpy/binary_bundling/bundle.py

  Log Message:
  -----------
  [Tools][GTK][WPE] generate-bundle: Improve the universal bundle with a C wrapper and support for GTK4
https://bugs.webkit.org/show_bug.cgi?id=280523

Reviewed by Carlos Garcia Campos.

Improve the support for generating universal bundles with via the script
"generate-bundle --syslibs=all" with the following changes:

- Use a C wrapper instead of a shell one. This allows to statically build
  the C wrapper so the bundle doesn't need to call the host shell interpreter,
  this avoids issues related to calling host binaries from inside the environment
  of the bundle and also makes the bundle startup faster.
- Add support for GTK4 for the WebKitGTK bundles: is not needed anymore to
  bundle the immodules plugins because those are gone in GTK4.
  Remove GTK3 support because we won't generate WebKitGTK bundles with it anymore.
- Improve support for pipewire plugins: bundle both the SPA plugins and the
  pipewire ones.
- Bundle the Sparkle CDM if available.
- Add some fixups for the last version of the Flatpak SDK related to fonts
  and icons.
- Add support for specifying the compression level of the bundle (1 to 9)
- Do not start the sandbox when using the bundle. It doesn't work because
  we can't execute binaries from the host (bwrap) under the bundle environment.

* Tools/Scripts/generate-bundle:
(TarArchiver):
(TarArchiver.__init__):
(ZipArchiver):
(ZipArchiver.__init__):
(BundleCreator):
(BundleCreator.__init__):
(BundleCreator._generate_readme):
(BundleCreator._generate_wrapper):
(BundleCreator.create):
(BundleCreator._get_gtk_modules):
(BundleCreator._get_gdk_query_loaders_binary):
(BundleCreator._get_pipewire_spa_basedir_and_plugins):
(BundleCreator._get_pipewire_basedir_and_modules):
(BundleCreator._get_sparkle_cdm_plugins):
(BundleCreator._create_bundle):
(main):
(BundleCreator._generate_wrapper_script): Deleted.
(BundleCreator._get_gtk_query_immodules_binary): Deleted.
* Tools/Scripts/webkitpy/binary_bundling/bundle.py:
(BinaryBundler._run_cmd_and_get_output):
(BinaryBundler):
(BinaryBundler._run_cmd_or_log_fail):
(BinaryBundler.copy_and_maybe_strip_patchelf):
(BinaryBundler.is_xkb_bundled):
(BinaryBundler.generate_wrapper_script):
(BinaryBundler.generate_and_build_static_cwrapper):

Canonical link: https://commits.webkit.org/285012@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications