[webkit-changes] [WebKit/WebKit] d0795f: [Win] Fix problems of SystemInfo.cpp

Fujii Hironori noreply at github.com
Fri Oct 11 02:07:37 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d0795f0c2fa2986c03472c1ed35bf7d17c02fe5a
      https://github.com/WebKit/WebKit/commit/d0795f0c2fa2986c03472c1ed35bf7d17c02fe5a
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2024-10-11 (Fri, 11 Oct 2024)

  Changed paths:
    M Source/WebCore/platform/win/CursorWin.cpp
    M Source/WebCore/platform/win/SystemInfo.cpp
    M Source/WebCore/platform/win/SystemInfo.h
    M Source/WebKit/win/WebKit.manifest
    M Tools/MiniBrowser/win/MiniBrowser.exe.manifest
    M Tools/WebKitTestRunner/win/WebKitTestRunner.exe.manifest

  Log Message:
  -----------
  [Win] Fix problems of SystemInfo.cpp
https://bugs.webkit.org/show_bug.cgi?id=280295

Reviewed by Ross Kirsling.

GetVersionEx API always returned the Windows 8 version number.
<https://learn.microsoft.com/en-us/windows/win32/api/sysinfoapi/nf-sysinfoapi-getversionexa>
Added supportedOS to application manifests to make the API work as
expected on newer Windows.

GetNativeSystemInfo API is available after Windows XP and Windows
Server 2003.
<https://learn.microsoft.com/en-us/windows/win32/api/sysinfoapi/nf-sysinfoapi-getnativesysteminfo>
We no longer need to use GetProcAddress for it.

Removed the code for old Windows in WebCore::createSharedCursor.

* Source/WebCore/platform/win/CursorWin.cpp:
(WebCore::createSharedCursor):
* Source/WebCore/platform/win/SystemInfo.cpp:
(WebCore::windowsVersion):
(WebCore::processorArchitecture):
(WebCore::architectureTokenForUAString):
(WebCore::windowsVersionForUAString):
(WebCore::osVersionForUAString): Deleted.
* Source/WebCore/platform/win/SystemInfo.h:
* Source/WebKit/win/WebKit.manifest:
* Tools/MiniBrowser/win/MiniBrowser.exe.manifest:
* Tools/WebKitTestRunner/win/WebKitTestRunner.exe.manifest:

Canonical link: https://commits.webkit.org/285009@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list