[webkit-changes] [WebKit/WebKit] 24c8f5: [WebGPU] Minimum binding size for validation needs...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 24c8f5f321a0569ad1d02ebb3d45675af50e9539
      https://github.com/WebKit/WebKit/commit/24c8f5f321a0569ad1d02ebb3d45675af50e9539
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-10-10 (Thu, 10 Oct 2024)

  Changed paths:
    A LayoutTests/fast/webgpu/nocrash/repro-281057-expected.txt
    A LayoutTests/fast/webgpu/nocrash/repro-281057.html
    M Source/WebGPU/WebGPU/BindGroup.mm
    M Source/WebGPU/WebGPU/BindableResource.h
    M Source/WebGPU/WebGPU/Pipeline.mm

  Log Message:
  -----------
  [WebGPU] Minimum binding size for validation needs to be max of user specified and value in WGSL source
https://bugs.webkit.org/show_bug.cgi?id=281057
rdar://137262987

Reviewed by Tadeu Zagallo.

Ensure entrySize is at least the size of the minimum binding size
computed in the shader parsing.

* LayoutTests/fast/webgpu/nocrash/repro-281057-expected.txt: Added.
* LayoutTests/fast/webgpu/nocrash/repro-281057.html: Added.
Add regression test.

* Source/WebGPU/WebGPU/BindGroup.mm:
(WebGPU::makeBindGroupEntryUsageData):
(WebGPU::Device::createBindGroup):
* Source/WebGPU/WebGPU/BindableResource.h:
* Source/WebGPU/WebGPU/Pipeline.mm:
(WebGPU::errorValidatingBindGroup):

Canonical link: https://commits.webkit.org/284987@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications