[webkit-changes] [WebKit/WebKit] 82e720: [scroll-animations] computeTimelineData should use...

[Nikos Mouchtaris]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 82e7204a3495efa4f626a78e0acff54d16e14663
      https://github.com/WebKit/WebKit/commit/82e7204a3495efa4f626a78e0acff54d16e14663
  Author: Nikolaos Mouchtaris <nmouchtaris at apple.com>
  Date:   2024-10-10 (Thu, 10 Oct 2024)

  Changed paths:
    M Source/WebCore/animation/ScrollTimeline.cpp
    M Source/WebCore/animation/ScrollTimeline.h
    M Source/WebCore/animation/ViewTimeline.cpp

  Log Message:
  -----------
  [scroll-animations] computeTimelineData should use 0 for normal or auto animation-range offsets
https://bugs.webkit.org/show_bug.cgi?id=281172
rdar://137633788

Reviewed by Simon Fraser.

floatValueForLength defaults to using the max value when the length is normal or auto. We want the
value to be 0 instead, so make a wrapper static function for this.

* Source/WebCore/animation/ScrollTimeline.cpp:
(WebCore::ScrollTimeline::floatValueForOffset):
(WebCore::ScrollTimeline::computeTimelineData const):
* Source/WebCore/animation/ScrollTimeline.h:
* Source/WebCore/animation/ViewTimeline.cpp:
(WebCore::ViewTimeline::computeTimelineData const):
* Source/WebKit/UIProcess/BrowsingContextGroup.cpp:
(WebKit::BrowsingContextGroup::addFrameProcess):

Canonical link: https://commits.webkit.org/284980@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications