[webkit-changes] [WebKit/WebKit] 4c7e20: WebAuthenticationEnabled set in WKPreferences is i...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4c7e20910b3439fe4b6aab7be3a94b3210e6d05f
      https://github.com/WebKit/WebKit/commit/4c7e20910b3439fe4b6aab7be3a94b3210e6d05f
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2024-10-10 (Thu, 10 Oct 2024)

  Changed paths:
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPreferences.mm

  Log Message:
  -----------
  WebAuthenticationEnabled set in WKPreferences is ignored
https://bugs.webkit.org/show_bug.cgi?id=281170
rdar://137629974

Reviewed by Ryosuke Niwa and Brent Fulgham.

WebPage::updatePreferences() always sets WebAuthenticationEnabled to true on iOS when app is a browser, regardless of
the value in WebPreferences. This means client cannot disable Web Authentication even though the SPI exists. Now that
WebAuthenticationEnabled is always true by default (see UnifiedWebPreferences), we should just drop the setting in
updatePreferences() and let client disable it on demand via WKWebPreferences SPI.

Mark Web Authentication API as rich JavaScript feature and update API test to cover it. Without this fix, the test would
fail as the flag value cannot be changed.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPreferences.mm:
(DisableRichJavaScriptFeatures)):

Canonical link: https://commits.webkit.org/284977@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications