[webkit-changes] [WebKit/WebKit] fff8fc: Unreviewed fix, [Static Analyzer CI] Fixed files f...

Brianna Fan noreply at github.com
Thu Oct 10 08:36:20 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fff8fcf6d15d71f0f5f0ebc6fdc701b2e68673af
      https://github.com/WebKit/WebKit/commit/fff8fcf6d15d71f0f5f0ebc6fdc701b2e68673af
  Author: Brianna Fan <bfan2 at apple.com>
  Date:   2024-10-10 (Thu, 10 Oct 2024)

  Changed paths:
    M Tools/CISupport/ews-build/steps.py

  Log Message:
  -----------
  Unreviewed fix, [Static Analyzer CI] Fixed files from different builds appear in other PR comments
https://bugs.webkit.org/show_bug.cgi?id=281228
rdar://137649620

Setting commands as a class property actually persists over multiple builds.
Thus, PR comments would include every command ever added to that set.
Make commands_to_comment a local variable that's passed into the relevant methods as a parameter.

* Tools/CISupport/ews-build/steps.py:
(DisplaySaferCPPResults):
(DisplaySaferCPPResults.run):
(DisplaySaferCPPResults.getFilesPerProject):
(DisplaySaferCPPResults.createComment):

Canonical link: https://commits.webkit.org/284969@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list