[webkit-changes] [WebKit/WebKit] 9bfbbb: Unreviewed, reverting 284931 at main and 284940 at main.

Thu Oct 10 03:38:36 PDT 2024

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9bfbbb1fe8f030b8d313a2a97d431b1c50d95d37
      https://github.com/WebKit/WebKit/commit/9bfbbb1fe8f030b8d313a2a97d431b1c50d95d37
  Author: Commit Queue <commit-queue at webkit.org>
  Date:   2024-10-10 (Thu, 10 Oct 2024)

  Changed paths:
    M JSTests/stress/big-int-strict-spec-to-this.js
    R JSTests/stress/evaluate-with-scope-extension.js
    R JSTests/stress/global-object-accessor-property-this-value.js
    R JSTests/stress/variable-named-eval.js
    M LayoutTests/fast/dom/Window/dom-access-from-closure-iframe-expected.txt
    M LayoutTests/fast/dom/Window/dom-access-from-closure-window-expected.txt
    M LayoutTests/fast/dom/Window/dom-access-from-closure-window-with-gc-expected.txt
    M LayoutTests/http/tests/security/xss-DENIED-htmlelelment-with-iframe-proto-expected.txt
    M LayoutTests/http/tests/security/xss-DENIED-method-with-iframe-proto-expected.txt
    M LayoutTests/http/tests/security/xss-DENIED-non-shadowable-propterty-with-iframe-proto-expected.txt
    M LayoutTests/http/tests/security/xss-DENIED-regular-propterty-with-iframe-proto-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/global-object-implicit-this-value-cross-realm-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/global-object-implicit-this-value.any-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/global-object-implicit-this-value.any.serviceworker-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/global-object-implicit-this-value.any.sharedworker-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/global-object-implicit-this-value.any.worker-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/browsers/windows/embedded-opener-remove-frame-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/execution-timing/083-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/websockets/unload-a-document/001_default-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/websockets/unload-a-document/001_wss-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/websockets/unload-a-document/002_default-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/websockets/unload-a-document/002_wss-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/websockets/unload-a-document/003-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/websockets/unload-a-document/004-expected.txt
    M LayoutTests/js/object-literal-shorthand-construction-expected.txt
    M LayoutTests/js/script-tests/object-literal-shorthand-construction.js
    M LayoutTests/storage/indexeddb/resources/crash-on-getdatabases.js
    M Source/JavaScriptCore/API/APICallbackFunction.h
    M Source/JavaScriptCore/API/JSBase.cpp
    M Source/JavaScriptCore/API/JSCallbackObjectFunctions.h
    M Source/JavaScriptCore/API/JSContextRef.cpp
    M Source/JavaScriptCore/API/JSObjectRef.cpp
    M Source/JavaScriptCore/API/JSScriptRef.cpp
    M Source/JavaScriptCore/API/tests/testapi.c
    M Source/JavaScriptCore/CMakeLists.txt
    M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
    M Source/JavaScriptCore/Sources.txt
    M Source/JavaScriptCore/builtins/ProxyHelpers.js
    M Source/JavaScriptCore/bytecode/BytecodeIntrinsicRegistry.h
    M Source/JavaScriptCore/bytecode/BytecodeList.rb
    M Source/JavaScriptCore/bytecode/CodeBlock.cpp
    M Source/JavaScriptCore/bytecode/SpeculatedType.cpp
    M Source/JavaScriptCore/bytecode/SpeculatedType.h
    A Source/JavaScriptCore/bytecode/ToThisStatus.cpp
    A Source/JavaScriptCore/bytecode/ToThisStatus.h
    M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp
    M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h
    M Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp
    M Source/JavaScriptCore/debugger/DebuggerCallFrame.cpp
    M Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h
    M Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp
    M Source/JavaScriptCore/dfg/DFGClobberize.h
    M Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp
    M Source/JavaScriptCore/dfg/DFGFixupPhase.cpp
    M Source/JavaScriptCore/dfg/DFGGraph.h
    M Source/JavaScriptCore/dfg/DFGNode.h
    M Source/JavaScriptCore/dfg/DFGOpInfo.h
    M Source/JavaScriptCore/dfg/DFGOperations.cpp
    M Source/JavaScriptCore/dfg/DFGOperations.h
    M Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp
    M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp
    M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp
    M Source/JavaScriptCore/generator/DSL.rb
    M Source/JavaScriptCore/inspector/JSInjectedScriptHost.cpp
    M Source/JavaScriptCore/interpreter/Interpreter.cpp
    M Source/JavaScriptCore/jit/AssemblyHelpers.h
    M Source/JavaScriptCore/jit/JITOpcodes.cpp
    M Source/JavaScriptCore/jit/JITOperations.cpp
    M Source/JavaScriptCore/llint/LLIntSlowPaths.cpp
    M Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm
    M Source/JavaScriptCore/llint/LowLevelInterpreter64.asm
    M Source/JavaScriptCore/runtime/ArrayPrototype.cpp
    M Source/JavaScriptCore/runtime/AsyncIteratorPrototype.cpp
    M Source/JavaScriptCore/runtime/CommonSlowPaths.cpp
    M Source/JavaScriptCore/runtime/Completion.cpp
    M Source/JavaScriptCore/runtime/DatePrototype.cpp
    M Source/JavaScriptCore/runtime/ErrorPrototype.cpp
    M Source/JavaScriptCore/runtime/JSCJSValue.cpp
    M Source/JavaScriptCore/runtime/JSCJSValue.h
    M Source/JavaScriptCore/runtime/JSCJSValueInlines.h
    M Source/JavaScriptCore/runtime/JSCast.h
    M Source/JavaScriptCore/runtime/JSGlobalObject.h
    M Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp
    M Source/JavaScriptCore/runtime/JSIteratorPrototype.cpp
    M Source/JavaScriptCore/runtime/JSObject.cpp
    M Source/JavaScriptCore/runtime/JSObject.h
    M Source/JavaScriptCore/runtime/JSScope.h
    M Source/JavaScriptCore/runtime/JSType.h
    M Source/JavaScriptCore/runtime/ObjectPrototype.cpp
    M Source/JavaScriptCore/runtime/ProxyObject.cpp
    M Source/JavaScriptCore/runtime/RegExpPrototype.cpp
    M Source/JavaScriptCore/runtime/SparseArrayValueMap.cpp
    M Source/JavaScriptCore/runtime/StringPrototype.cpp
    M Source/WebCore/bindings/js/JSDOMOperation.h
    M Source/WebCore/bindings/js/JSDOMOperationReturningPromise.h
    M Source/WebCore/bindings/js/JSDOMWindowCustom.cpp
    M Source/WebCore/bindings/js/JSErrorHandler.cpp
    M Source/WebCore/bindings/js/JSEventTargetCustom.h
    M Source/WebCore/bindings/js/ScheduledAction.cpp
    M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
    M Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp
    M Source/WebCore/bindings/scripts/test/TestGlobalObject.idl
    M Source/WebCore/html/HTMLMediaElement.cpp

  Log Message:
  -----------
  Unreviewed, reverting 284931 at main and 284940 at main.
https://bugs.webkit.org/show_bug.cgi?id=281214

sub-1% JS2 perf regression

Reverted changesets:

"[JSC] Don't use JSScope instances as `this` value when calling functions"
https://bugs.webkit.org/show_bug.cgi?id=225397
https://commits.webkit.org/284931@main

"REGRESSION(284931 at main): imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/global-object-implicit-this-value.any.serviceworker.html is failing"
https://bugs.webkit.org/show_bug.cgi?id=225397
https://commits.webkit.org/284940@main

Canonical link: https://commits.webkit.org/284962@main

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications