[webkit-changes] [WebKit/WebKit] 07c17a: [JSC] Remove ICU version checks from stress tests

SUZUKI Sosuke noreply at github.com
Wed Oct 9 23:08:10 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 07c17a554ff1179adfbc52d7b3afb41b3446446b
      https://github.com/WebKit/WebKit/commit/07c17a554ff1179adfbc52d7b3afb41b3446446b
  Author: Sosuke Suzuki <aosukeke at gmail.com>
  Date:   2024-10-09 (Wed, 09 Oct 2024)

  Changed paths:
    M JSTests/stress/intl-canonical-locale-alias-mapping.js
    M JSTests/stress/intl-collator.js
    M JSTests/stress/intl-datetimeformat-formatrange-relevant-extensions-ja.js
    M JSTests/stress/intl-datetimeformat-formatrange-relevant-extensions.js
    M JSTests/stress/intl-datetimeformat-formatrangetoparts-relevant-extensions-ja.js
    M JSTests/stress/intl-datetimeformat-formatrangetoparts-relevant-extensions.js
    M JSTests/stress/intl-datetimeformat.js
    M JSTests/stress/intl-displaynames-v2.js
    M JSTests/stress/intl-displaynames.js
    M JSTests/stress/intl-durationformat-basic.js
    M JSTests/stress/intl-durationformat-format-to-parts.js
    M JSTests/stress/intl-durationformat.js
    M JSTests/stress/intl-language-tag.js
    M JSTests/stress/intl-listformat.js
    M JSTests/stress/intl-locale.js
    M JSTests/stress/intl-numberformat-rounding-mode-table-v3.js
    M JSTests/stress/intl-numberformat-sign-display-v3.js
    M JSTests/stress/intl-numberformat-trailing-zero-display-v3.js
    M JSTests/stress/intl-numberformat-unified-ja.js
    M JSTests/stress/intl-numberformat-unified.js
    M JSTests/stress/intl-numberformat.js
    M JSTests/stress/intl-object.js
    M JSTests/stress/intl-parse-unicode-subtags.js
    M JSTests/stress/intl-pluralrules.js
    M JSTests/stress/intl-relativetimeformat.js

  Log Message:
  -----------
  [JSC] Remove ICU version checks from stress tests
https://bugs.webkit.org/show_bug.cgi?id=281147

Reviewed by Ross Kirsling.

Now, ICU baseline is 70, so https://commits.webkit.org/284654@main removed unnecessary runtime ICU
version checks.

This patch removes unnecessary ICU version checks from stress tests.

* JSTests/stress/intl-canonical-locale-alias-mapping.js:
(Intl.getCanonicalLocales):
* JSTests/stress/intl-collator.js:
* JSTests/stress/intl-datetimeformat-formatrange-relevant-extensions-ja.js:
(vm.icuVersion): Deleted.
* JSTests/stress/intl-datetimeformat-formatrange-relevant-extensions.js:
* JSTests/stress/intl-datetimeformat-formatrangetoparts-relevant-extensions-ja.js:
(Intl.DateTimeFormat.prototype.formatRangeToParts.shouldBeParts.fmt5.formatRangeToParts):
(Intl.DateTimeFormat.prototype.formatRangeToParts.shouldBeParts.fmt8.formatRangeToParts):
(Intl.DateTimeFormat.prototype.formatRangeToParts.shouldBeParts.fmt9.formatRangeToParts):
(Intl.DateTimeFormat.prototype.formatRangeToParts.shouldBeParts.fmt12.formatRangeToParts):
(Intl.DateTimeFormat.prototype.formatRangeToParts.vm.icuVersion): Deleted.
* JSTests/stress/intl-datetimeformat-formatrangetoparts-relevant-extensions.js:
* JSTests/stress/intl-datetimeformat.js:
(shouldBeForICUVersion): Deleted.
* JSTests/stress/intl-displaynames-v2.js:
(shouldThrow):
(displayNames.of):
(shouldBe):
(vm.icuVersion): Deleted.
* JSTests/stress/intl-displaynames.js:
(shouldBe.JSON.stringify.currencyNames.resolvedOptions):
(shouldBe.JSON.stringify.regionNames.resolvedOptions):
(object.toString):
(RangeError.invalid.language.tag.shouldThrow):
(TypeError.Intl.DisplayNames.prototype.of.called.on.value.that.shouldThrow):
(vm.icuVersion): Deleted.
* JSTests/stress/intl-durationformat-basic.js:
(shouldBeForICUVersion): Deleted.
* JSTests/stress/intl-durationformat-format-to-parts.js:
(shouldBeForICUVersion): Deleted.
* JSTests/stress/intl-durationformat.js:
* JSTests/stress/intl-language-tag.js:
* JSTests/stress/intl-listformat.js:
* JSTests/stress/intl-locale.js:
* JSTests/stress/intl-numberformat-rounding-mode-table-v3.js:
(Object.keys.expectations.forEach):
* JSTests/stress/intl-numberformat-sign-display-v3.js:
* JSTests/stress/intl-numberformat-trailing-zero-display-v3.js:
* JSTests/stress/intl-numberformat-unified-ja.js:
(vm.icuVersion.64.vm.icuHeaderVersion): Deleted.
* JSTests/stress/intl-numberformat-unified.js:
(vm.icuVersion.64.vm.icuHeaderVersion): Deleted.
* JSTests/stress/intl-numberformat.js:
* JSTests/stress/intl-object.js:
* JSTests/stress/intl-parse-unicode-subtags.js:
(vm.icuVersion): Deleted.
* JSTests/stress/intl-pluralrules.js:
* JSTests/stress/intl-relativetimeformat.js:
(shouldBeForICUVersion): Deleted.

Canonical link: https://commits.webkit.org/284954@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list