[webkit-changes] [WebKit/WebKit] d98621: Changing "scrolling" attribute on iframe element a...

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d98621968e3c4fa3d341b921906050b26fd20152
      https://github.com/WebKit/WebKit/commit/d98621968e3c4fa3d341b921906050b26fd20152
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2024-10-09 (Wed, 09 Oct 2024)

  Changed paths:
    A LayoutTests/compositing/iframes/iframe-scrolling-change-expected.txt
    A LayoutTests/compositing/iframes/iframe-scrolling-change.html
    M LayoutTests/platform/ios/TestExpectations
    M Source/WebCore/html/HTMLFrameElementBase.cpp
    M Source/WebCore/page/Frame.cpp
    M Source/WebCore/page/Frame.h
    M Source/WebCore/page/LocalFrame.cpp
    M Source/WebCore/page/LocalFrame.h
    M Source/WebCore/page/LocalFrameView.cpp

  Log Message:
  -----------
  Changing "scrolling" attribute on iframe element already in DOM doesn't take effect.
https://bugs.webkit.org/show_bug.cgi?id=24070
<rdar://98911472>

Reviewed by Simon Fraser.

Stores the value of the scrollingMode on the LocalFrame, largely as site-isolation preparation, since the owning element won't always be available.

On mutation of the 'scrolling' attribute, update the LocalFrame's value and notify the LocalFrameView of the change.

Adds a test that adds scrolling, and uses the renderer dump to confirm that the inner view got resized to make space for the scrollbars.

* LayoutTests/compositing/iframes/iframe-scrolling-change-expected.txt: Added.
* LayoutTests/compositing/iframes/iframe-scrolling-change.html: Added.
* Source/WebCore/html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::attributeChanged):
* Source/WebCore/page/Frame.cpp:
(WebCore::Frame::setOwnerElement):
* Source/WebCore/page/Frame.h:
(WebCore::Frame::updateScrollingMode):
* Source/WebCore/page/LocalFrame.cpp:
(WebCore::LocalFrame::LocalFrame):
(WebCore::LocalFrame::updateScrollingMode):
* Source/WebCore/page/LocalFrame.h:
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::init):
(WebCore::LocalFrameView::calculateScrollbarModesForLayout):
(WebCore::LocalFrameView::scrollRectToVisibleInChildView):

Canonical link: https://commits.webkit.org/284947@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications