[webkit-changes] [WebKit/WebKit] 55e501: [WebGPU] Ensure bind group writes to all slots in ...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 55e501a9b8bed5fb2676004c51eaa612bd0ac4df
      https://github.com/WebKit/WebKit/commit/55e501a9b8bed5fb2676004c51eaa612bd0ac4df
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-10-09 (Wed, 09 Oct 2024)

  Changed paths:
    A LayoutTests/fast/webgpu/null_buffers_in_bind_group-expected.txt
    A LayoutTests/fast/webgpu/null_buffers_in_bind_group.html
    M Source/WebGPU/WebGPU/BindGroup.mm
    M Source/WebGPU/WebGPU/BindGroupLayout.h
    M Source/WebGPU/WebGPU/BindGroupLayout.mm

  Log Message:
  -----------
  [WebGPU] Ensure bind group writes to all slots in the encoder
https://bugs.webkit.org/show_bug.cgi?id=279695
rdar://135732389

Reviewed by Tadeu Zagallo.

Ensure during bind group creation that the corresponding BindGroupLayout,
which essentially corresponds to the struct layout in the shader, is completely
populated. Otherwise, treat the bind group as invalid.

* LayoutTests/fast/webgpu/null_buffers_in_bind_group-expected.txt: Added.
* LayoutTests/fast/webgpu/null_buffers_in_bind_group.html: Added.
* Source/WebGPU/WebGPU/BindGroup.mm:
(WebGPU::Device::createBindGroup):
* Source/WebGPU/WebGPU/BindGroupLayout.h:
(WebGPU::BindGroupLayout::create):
* Source/WebGPU/WebGPU/BindGroupLayout.mm:
(WebGPU::Device::createBindGroupLayout):
(WebGPU::BindGroupLayout::BindGroupLayout):
(WebGPU::BindGroupLayout::argumentIndices const):

Canonical link: https://commits.webkit.org/284945@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications