[webkit-changes] [WebKit/WebKit] 9784c8: Make it possible to generate text previews for a p...

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9784c8983ab995cac95a30e90acba5032ecfe6a0
      https://github.com/WebKit/WebKit/commit/9784c8983ab995cac95a30e90acba5032ecfe6a0
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2024-10-09 (Wed, 09 Oct 2024)

  Changed paths:
    M Source/WebCore/dom/StyledElement.h
    M Source/WebKit/SourcesCocoa.txt
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
    A Source/WebKit/UIProcess/API/Cocoa/_WKTextPreview.h
    A Source/WebKit/UIProcess/API/Cocoa/_WKTextPreview.mm
    M Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationCoordinator.h
    M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
    M Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Source/WebKit/WebProcess/WebPage/WebPage.messages.in

  Log Message:
  -----------
  Make it possible to generate text previews for a particular HTML element
https://bugs.webkit.org/show_bug.cgi?id=281105
rdar://137559148

Reviewed by Aditya Keerthi.

Expose functionality to be able to generate text previews or a UITargetedPreview for the text of a particular element, given its id.

This is a mutating operation, as the content has to temporarily be forced to be visible, and is then restored to its original state.

* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/dom/StyledElement.h:
* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _targetedPreviewForElementWithID:completionHandler:]):
(-[WKWebView _textPreviewsForElementWithID:completionHandler:]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKTextPreview.h: Copied from Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationCoordinator.h.
* Source/WebKit/UIProcess/API/Cocoa/_WKTextPreview.mm: Copied from Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationCoordinator.h.
(-[_WKTextPreview initWithSnapshotImage:presentationFrame:]):
(-[_WKTextPreview previewImage]):
* Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationCoordinator.h:
* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::createTextIndicatorForElementWithID):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _createTargetedPreviewFromTextIndicator:previewContainer:]):
(-[WKContentView _createTargetedContextMenuHintPreviewIfPossible]):
(-[WKContentView targetedPreviewForID:completionHandler:]):
(-[WKContentView callCompletionHandlerForAnimationID:completionHandler:]):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/WebPage/Cocoa/TextAnimationController.h:
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::elementHasHiddenVisibility):
(WebKit::WebPage::createTextIndicatorForElementWithID):
(WebKit::WebPage::enableSourceTextAnimationAfterElementWithID): Deleted.
(WebKit::WebPage::enableTextAnimationTypeForElementWithID): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:

Canonical link: https://commits.webkit.org/284942@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications