[webkit-changes] [WebKit/WebKit] 3f1856: [site-isolation] RenderLayerBacking::updateAfterWi...

mattwoodrow noreply at github.com
Wed Oct 9 15:37:37 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3f1856724b13559497e7b328658134b75cbd23a9
      https://github.com/WebKit/WebKit/commit/3f1856724b13559497e7b328658134b75cbd23a9
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2024-10-09 (Wed, 09 Oct 2024)

  Changed paths:
    A LayoutTests/http/tests/site-isolation/compositing/iframes/overlapped-nested-iframes-expected.txt
    A LayoutTests/http/tests/site-isolation/compositing/iframes/overlapped-nested-iframes.html
    A LayoutTests/platform/ios/http/tests/site-isolation/compositing/iframes/overlapped-nested-iframes-expected.txt
    M Source/WebCore/page/LocalFrameView.cpp
    M Source/WebCore/page/LocalFrameView.h
    M Source/WebCore/page/RemoteFrameClient.h
    M Source/WebCore/page/RemoteFrameView.cpp
    M Source/WebCore/page/RemoteFrameView.h
    M Source/WebCore/platform/Widget.h
    M Source/WebCore/rendering/RenderLayerBacking.cpp
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.messages.in
    M Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.h
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Source/WebKit/WebProcess/WebPage/WebPage.messages.in

  Log Message:
  -----------
  [site-isolation] RenderLayerBacking::updateAfterWidgetResize needs to notify cross-process subframe RenderLayerCompositors of bounds changing.
https://bugs.webkit.org/show_bug.cgi?id=280958
<rdar://137406024>

Reviewed by Sihui Liu.

Instead of trying to access RenderLayerCompositor for a subframe directly, notify the FrameView instead.
Implement this for a RemoteFrameView by sending it across IPC to the relevant LocalFrameView.

As with bug 280874, this test is a direct copy of an existing one, updated to be cross-origin.

* LayoutTests/http/tests/site-isolation/compositing/iframes/overlapped-nested-iframes-expected.txt: Added.
* LayoutTests/http/tests/site-isolation/compositing/iframes/overlapped-nested-iframes.html: Added.
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::compositedBoundsChanged):
* Source/WebCore/page/LocalFrameView.h:
* Source/WebCore/page/RemoteFrameClient.h:
* Source/WebCore/page/RemoteFrameView.cpp:
(WebCore::RemoteFrameView::compositedBoundsChanged):
* Source/WebCore/page/RemoteFrameView.h:
* Source/WebCore/platform/Widget.h:
(WebCore::Widget::compositedBoundsChanged):
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateAfterWidgetResize):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::frameCompositedBoundsChanged):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp:
(WebKit::WebRemoteFrameClient::compositedBoundsChanged):
* Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::frameCompositedBoundsChanged):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:

Canonical link: https://commits.webkit.org/284932@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list