[webkit-changes] [WebKit/WebKit] b1ed27: [scroll-animations] implement `ScrollTimeline.curr...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b1ed27f4948073a31795dc90b845554fda214420
      https://github.com/WebKit/WebKit/commit/b1ed27f4948073a31795dc90b845554fda214420
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2024-10-09 (Wed, 09 Oct 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/scroll-timelines/current-time-root-scroller-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/scroll-timelines/scroll-timeline-snapshotting-expected.txt
    M Source/WebCore/animation/ScrollTimeline.cpp
    M Source/WebCore/animation/ScrollTimeline.h
    M Source/WebCore/animation/ViewTimeline.cpp
    M Source/WebCore/animation/ViewTimeline.h

  Log Message:
  -----------
  [scroll-animations] implement `ScrollTimeline.currentTime`
https://bugs.webkit.org/show_bug.cgi?id=281126
rdar://137575125

Reviewed by Anne van Kesteren.

The timeline data computation in `ScrollTimeline` and `ViewTimeline` yields identical data structures,
so we remove the `ViewTimeline::Data` structure in favor of just `ScrollTimeline::Data`. Then we compute
this data in the virtual method `ScrollTimeline::computeTimelineData()`.

The computed data is then used to compute the resulting `currentTime`.

* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/scroll-timelines/current-time-root-scroller-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/scroll-timelines/scroll-timeline-snapshotting-expected.txt:
* Source/WebCore/animation/ScrollTimeline.cpp:
(WebCore::ScrollTimeline::computeTimelineData const):
(WebCore::ScrollTimeline::currentTime):
(WebCore::ScrollTimeline::computeScrollTimelineData const): Deleted.
* Source/WebCore/animation/ScrollTimeline.h:
(WebCore::ScrollTimeline::computeTimelineData):
(WebCore::ScrollTimeline::computeScrollTimelineData): Deleted.
* Source/WebCore/animation/ViewTimeline.cpp:
(WebCore::ViewTimeline::computeTimelineData const):
(WebCore::ViewTimeline::startOffset const):
(WebCore::ViewTimeline::endOffset const):
(WebCore::ViewTimeline::computeViewTimelineData const): Deleted.
* Source/WebCore/animation/ViewTimeline.h:

Canonical link: https://commits.webkit.org/284928@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications