[webkit-changes] [WebKit/WebKit] f40822: AudioSampleBufferCompressor and VideoSampleBufferC...

Jean-Yves Avenard noreply at github.com
Wed Oct 9 14:29:10 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f40822a656dc370b02a88bac25f1beb96ad9ad3f
      https://github.com/WebKit/WebKit/commit/f40822a656dc370b02a88bac25f1beb96ad9ad3f
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2024-10-09 (Wed, 09 Oct 2024)

  Changed paths:
    M Source/WebCore/platform/mediarecorder/cocoa/AudioSampleBufferCompressor.h
    M Source/WebCore/platform/mediarecorder/cocoa/AudioSampleBufferCompressor.mm
    M Source/WebCore/platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.h
    M Source/WebCore/platform/mediarecorder/cocoa/VideoSampleBufferCompressor.h
    M Source/WebCore/platform/mediarecorder/cocoa/VideoSampleBufferCompressor.mm

  Log Message:
  -----------
  AudioSampleBufferCompressor and VideoSampleBufferCompressor are using sync dispatch
https://bugs.webkit.org/show_bug.cgi?id=281107
rdar://137560529

Reviewed by Youenn Fablet.

Dispatch frame to be compressed to the encoding WorkQueue asynchronously.
To safely do so, make both AudioSampleBufferCompressor and VideoSampleBufferCompressor
inheriting ThreadSafeRefCountedAndCanMakeThreadSafeWeakPtr

No change in observable behaviour, covered by existing tests.

* Source/WebCore/platform/mediarecorder/cocoa/AudioSampleBufferCompressor.h:
* Source/WebCore/platform/mediarecorder/cocoa/AudioSampleBufferCompressor.mm:
(WebCore::AudioSampleBufferCompressor::create):
(WebCore::AudioSampleBufferCompressor::addSampleBuffer):
* Source/WebCore/platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.h:
* Source/WebCore/platform/mediarecorder/cocoa/VideoSampleBufferCompressor.h:
* Source/WebCore/platform/mediarecorder/cocoa/VideoSampleBufferCompressor.mm:
(WebCore::VideoSampleBufferCompressor::create):
(WebCore::VideoSampleBufferCompressor::addSampleBuffer):

Canonical link: https://commits.webkit.org/284926@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list