[webkit-changes] [WebKit/WebKit] 05f1d0: Copy files provided by WKWebView clients on iOS th...

[lilyspiniolas]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 05f1d0ebb69cc7cb3d8d9d9afd5e51d22f801e48
      https://github.com/WebKit/WebKit/commit/05f1d0ebb69cc7cb3d8d9d9afd5e51d22f801e48
  Author: Lily Spiniolas <lily_spiniolas at apple.com>
  Date:   2024-10-09 (Wed, 09 Oct 2024)

  Changed paths:
    M Source/WebKit/UIProcess/Cocoa/UIDelegate.mm
    M Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.h
    M Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm

  Log Message:
  -----------
  Copy files provided by WKWebView clients on iOS that implement runOpenPanel instead of moving them
https://bugs.webkit.org/show_bug.cgi?id=280847
rdar://137172156

Reviewed by Wenson Hsieh.

UIDelegate::UIClient::runOpenPanel now copies the URLs provided by implementations of runOpenPanel
in WKUIDelegates rather than moving them. This ensures that the workaround for
https://bugs.webkit.org/show_bug.cgi?id=228683 will not result in files being lost if the URL
points to an original file rather than an imported copy.

TestWebKitAPI.WebKit.RunOpenPanelNonLatin1 has also been updated to now create a file at
the URL it tests since file uploads from runOpenPanel on iOS now only proceed if the file
was successfully copied, which is impossible without an actual file.

* Source/WebKit/UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::runOpenPanel):
* Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.h:
* Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
(-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):

Canonical link: https://commits.webkit.org/284904@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications